Issue 142460043: code review 142460043: text/template: type-check chained node as argument

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 142460043: code review 142460043: text/template: type-check chained node as argument (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
9 years, 7 months ago by r

Modified:
9 years, 7 months ago

Reviewers:
adg

CC:
golang-codereviews, adg

Visibility:
Public.

Description

text/template: type-check chained node as argument Was just a missing case (literally) in the type checker. Fixes issue 8473.

Patch Set 1 #

Patch Set 2 : diff -r 7809e33f731b21a582b5d66ea29db7f25459fb99 https://code.google.com/p/go/ #

Created: 9 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+10 lines, -0 lines)			Patch
	M	src/text/template/exec.go	View		1 chunk	+2 lines, -0 lines	0 comments	Download
	M	src/text/template/exec_test.go	View		2 chunks	+8 lines, -0 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

Hello golang-codereviews@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go/

9 years, 7 months ago (2014-09-22 22:58:46 UTC) #1

9 years, 7 months ago (2014-09-23 00:48:17 UTC) #3

*** Submitted as https://code.google.com/p/go/source/detail?r=48355ec55578 ***

text/template: type-check chained node as argument
Was just a missing case (literally) in the type checker.

Fixes issue 8473.

LGTM=adg
R=golang-codereviews, adg
CC=golang-codereviews
https://codereview.appspot.com/142460043

Expand All Messages | Collapse All Messages