Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(185)

Issue 14243043: Really fix the local provider startup.

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 7 months ago by thumper
Modified:
10 years, 7 months ago
Reviewers:
axw1, mp+188739
Visibility:
Public.

Description

Really fix the local provider startup. sudo -E causes upstart on saucy to default to use the user bus. --system was added to start and stop, but status was missed. Race conditions during startup masked this before. I've added another check in start so if the actual start fails, check to see if it is started. When the file is written to disk, upstart may start it before we do, particularly, upstart may start it between when we checked it wasn't running, and when we try to start it. A drive by fix to the livetests was added as version.Current was being used to source information from test metadata, and there weren't saucy images defined. The tests pass wtih the version specified with no other alterations. https://code.launchpad.net/~thumper/juju-core/upstart-system/+merge/188739 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : Really fix the local provider startup. #

Patch Set 3 : Really fix the local provider startup. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -10 lines) Patch
A [revision details] View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M environs/jujutest/livetests.go View 1 1 chunk +1 line, -1 line 0 comments Download
M upstart/upstart.go View 2 chunks +9 lines, -2 lines 0 comments Download
M upstart/upstart_test.go View 1 2 1 chunk +7 lines, -7 lines 0 comments Download

Messages

Total messages: 4
thumper
Please take a look.
10 years, 7 months ago (2013-10-01 22:14:43 UTC) #1
thumper
Please take a look.
10 years, 7 months ago (2013-10-01 22:32:35 UTC) #2
thumper
Please take a look.
10 years, 7 months ago (2013-10-02 00:19:03 UTC) #3
axw1
10 years, 7 months ago (2013-10-02 00:42:14 UTC) #4
On 2013/10/02 00:19:03, thumper wrote:
> Please take a look.

LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b