Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(945)

Issue 14229043: code review 14229043: gofmt: explain why lower bounds aren't automatically si... (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
9 years, 2 months ago by rh
Modified:
9 years, 2 months ago
Reviewers:
r
CC:
golang-dev, r
Visibility:
Public.

Description

gofmt: explain why lower bounds aren't automatically simplified Full credit goes to gri and rsc for their explanations.

Patch Set 1 #

Patch Set 2 : diff -r 664c8763de42 https://code.google.com/p/go #

Patch Set 3 : diff -r 664c8763de42 https://code.google.com/p/go #

Patch Set 4 : diff -r 664c8763de42 https://code.google.com/p/go #

Total comments: 1

Patch Set 5 : diff -r 664c8763de42 https://code.google.com/p/go #

Patch Set 6 : diff -r 664c8763de42 https://code.google.com/p/go #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M src/cmd/gofmt/simplify.go View 1 2 3 4 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 5
rh
Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go
9 years, 2 months ago (2013-10-01 19:28:32 UTC) #1
r
https://codereview.appspot.com/14229043/diff/9001/src/cmd/gofmt/simplify.go File src/cmd/gofmt/simplify.go (right): https://codereview.appspot.com/14229043/diff/9001/src/cmd/gofmt/simplify.go#newcode98 src/cmd/gofmt/simplify.go:98: // x, y := b[:n], b[n:] blank lines unnecessary. ...
9 years, 2 months ago (2013-10-01 21:45:40 UTC) #2
rh
Hello golang-dev@googlegroups.com, r@golang.org (cc: golang-dev@googlegroups.com), Please take another look.
9 years, 2 months ago (2013-10-02 14:28:59 UTC) #3
r
LGTM
9 years, 2 months ago (2013-10-03 17:54:40 UTC) #4
r
9 years, 2 months ago (2013-10-03 17:55:19 UTC) #5
*** Submitted as https://code.google.com/p/go/source/detail?r=5fee73dba552 ***

gofmt: explain why lower bounds aren't automatically simplified

Full credit goes to gri and rsc for their explanations.

R=golang-dev, r
CC=golang-dev
https://codereview.appspot.com/14229043

Committer: Rob Pike <r@golang.org>
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b