Issue 14229043: code review 14229043: gofmt: explain why lower bounds aren't automatically si...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 14229043: code review 14229043: gofmt: explain why lower bounds aren't automatically si... (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 6 months ago by rh

Modified:
10 years, 6 months ago

Reviewers:
r

CC:
golang-dev, r

Visibility:
Public.

Description

gofmt: explain why lower bounds aren't automatically simplified Full credit goes to gri and rsc for their explanations.

Patch Set 2 : diff -r 664c8763de42 https://code.google.com/p/go #

Patch Set 3 : diff -r 664c8763de42 https://code.google.com/p/go #

Patch Set 4 : diff -r 664c8763de42 https://code.google.com/p/go #

Total comments: 1

Patch Set 5 : diff -r 664c8763de42 https://code.google.com/p/go #

Patch Set 6 : diff -r 664c8763de42 https://code.google.com/p/go #

Created: 10 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -0 lines)			Patch
	M	src/cmd/gofmt/simplify.go	View	1 2 3 4	1 chunk	+4 lines, -0 lines	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go

10 years, 6 months ago (2013-10-01 19:28:32 UTC) #1

https://codereview.appspot.com/14229043/diff/9001/src/cmd/gofmt/simplify.go File src/cmd/gofmt/simplify.go (right): https://codereview.appspot.com/14229043/diff/9001/src/cmd/gofmt/simplify.go#newcode98 src/cmd/gofmt/simplify.go:98: // x, y := b[:n], b[n:] blank lines unnecessary. ...

10 years, 6 months ago (2013-10-01 21:45:40 UTC) #2

Hello golang-dev@googlegroups.com, r@golang.org (cc: golang-dev@googlegroups.com), Please take another look.

10 years, 6 months ago (2013-10-02 14:28:59 UTC) #3

10 years, 6 months ago (2013-10-03 17:55:19 UTC) #5

*** Submitted as https://code.google.com/p/go/source/detail?r=5fee73dba552 ***

gofmt: explain why lower bounds aren't automatically simplified

Full credit goes to gri and rsc for their explanations.

R=golang-dev, r
CC=golang-dev
https://codereview.appspot.com/14229043

Committer: Rob Pike <r@golang.org>

Expand All Messages | Collapse All Messages