Adjust formatting

Adjust formatting



https://code.launchpad.net/~gary/charms/precise/juju-gui/credentialConfig/+merge/188670

(do not edit description out of merge proposal)

[gary.poster, 2013-10-01 17:57:39]

Please take a look.

[gary.poster, 2013-10-01 18:01:04]

Added comment

https://codereview.appspot.com/14226043/diff/1/hooks/charmhelpers.py
File hooks/charmhelpers.py (right):

https://codereview.appspot.com/14226043/diff/1/hooks/charmhelpers.py#newcode4
hooks/charmhelpers.py:4: # This file is taken from the python-charmhelpers
package.  It is possibly no
I added this file because tests wouldn't pass without it even though it was
installed on my system, and for the reasons I describe in the comment.  Please
only review the comments I added.  The rest is unnecessary.

[benji, 2013-10-01 19:21:33]

LGTM

https://codereview.appspot.com/14226043/diff/1/Makefile
File Makefile (right):

https://codereview.appspot.com/14226043/diff/1/Makefile#newcode20
Makefile:20: libpython-dev
Most of the other line continuations use a tab and then four spaces.  Mixing
tabs and spaces isn't the greatest thing in the world, but neither are the deep,
deep indents caused by all-tabs-all-the-time.  I'm cool either way.

https://codereview.appspot.com/14226043/diff/1/hooks/install
File hooks/install (right):

https://codereview.appspot.com/14226043/diff/1/hooks/install#newcode24
hooks/install:24: # We need to install the Juju PPA, which we will do with a
It looks like this needs to be word wrapped with the line below.

[gary.poster, 2013-10-01 20:36:08]

*** Submitted:

Add password option to charm

In order to support ecosystems work, add a password option that lets the charm
pre-fill the password in the GUI.

To QA, start up the charm, and verify that you need to enter your password in
the GUI.  Do not log in, or if you do, log out afterwards.  Next, juju set
juju-gui password=[YOUR ADMIN SECRET] and wait about 20 seconds for the charm to
reconfigure itself.  Then go to the browser again and you should not have to log
in.

R=
CC=
https://codereview.appspot.com/14226043

[gary.poster, 2013-10-01 20:44:39]

On 2013/10/01 19:21:33, benji wrote:
> LGTM
> 
> https://codereview.appspot.com/14226043/diff/1/Makefile
> File Makefile (right):
> 
> https://codereview.appspot.com/14226043/diff/1/Makefile#newcode20
> Makefile:20: libpython-dev
> Most of the other line continuations use a tab and then four spaces.  Mixing
> tabs and spaces isn't the greatest thing in the world, but neither are the
deep,
> deep indents caused by all-tabs-all-the-time.  I'm cool either way.
> 
> https://codereview.appspot.com/14226043/diff/1/hooks/install
> File hooks/install (right):
> 
> https://codereview.appspot.com/14226043/diff/1/hooks/install#newcode24
> hooks/install:24: # We need to install the Juju PPA, which we will do with a
> It looks like this needs to be word wrapped with the line below.

Argh, sorry, I missed that you had requested changes.  Fixing.

[gary.poster, 2013-10-01 21:04:16]

*** Submitted:

Adjust formatting

R=
CC=
https://codereview.appspot.com/14226043