Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(162)

Issue 14222044: Update bundle token with unit and service counts

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 6 months ago by rharding
Modified:
10 years, 6 months ago
Reviewers:
jeff.pihach, mp+188682
Visibility:
Public.

Description

Update bundle token with unit and service counts - Count the services/units based off the data in the model. - Add tests for the model counting them and the token for displaying them properly. https://code.launchpad.net/~rharding/juju-gui/bundle-token-update/+merge/188682 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : Update bundle token with unit and service counts #

Patch Set 3 : Update bundle token with unit and service counts #

Total comments: 2

Patch Set 4 : Update bundle token with unit and service counts #

Unified diffs Side-by-side diffs Delta from patch set Stats (+90 lines, -2 lines) Patch
A [revision details] View 1 2 3 1 chunk +2 lines, -0 lines 0 comments Download
M app/models/bundle.js View 1 chunk +37 lines, -0 lines 0 comments Download
M app/templates/bundle-token.handlebars View 1 chunk +1 line, -1 line 0 comments Download
M app/widgets/token.js View 1 2 3 2 chunks +21 lines, -1 line 0 comments Download
M test/test_model_bundle.js View 1 1 chunk +10 lines, -0 lines 0 comments Download
M test/test_token.js View 1 2 1 chunk +19 lines, -0 lines 0 comments Download

Messages

Total messages: 4
rharding
Please take a look.
10 years, 6 months ago (2013-10-01 18:59:40 UTC) #1
rharding
Please take a look.
10 years, 6 months ago (2013-10-01 19:03:07 UTC) #2
jeff.pihach
LGTM with some trivials if you so choose, thanks for the code! https://codereview.appspot.com/14222044/diff/6001/app/models/bundle.js File app/models/bundle.js ...
10 years, 6 months ago (2013-10-01 19:14:58 UTC) #3
rharding
10 years, 6 months ago (2013-10-02 12:20:26 UTC) #4
*** Submitted:

Update bundle token with unit and service counts

- Count the services/units based off the data in the model.
- Add tests for the model counting them and the token for displaying them
properly.

R=jeff.pihach
CC=
https://codereview.appspot.com/14222044
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b