Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(277)

Issue 142200044: code review 142200044: net: allow all unix /etc/* pathes to be assignable.

Can't Edit
Can't Publish+Mail
Start Review
Created:
9 years, 9 months ago by oneofone
Modified:
2 weeks, 5 days ago
Reviewers:
federienzo, rsc
CC:
golang-codereviews, 0xjnml, iant, rsc
Visibility:
Public.

Description

net: allow all unix /etc/* pathes to be assignable. This fixes a major problem when compiling for Android or any other unix-based system that doesn't use the default /etc/{resolv.conf,hosts,protocols,services} pathes and it doesn't affect anything else at all. Fixes issue 8020. Fixes issue 8765.

Patch Set 1 #

Patch Set 2 : diff -r 6b163ec2122a172030284060788f535ab3b9d0e3 https://code.google.com/p/go #

Patch Set 3 : diff -r 6b163ec2122a172030284060788f535ab3b9d0e3 https://code.google.com/p/go #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -12 lines) Patch
M src/net/dnsclient_unix.go View 1 1 chunk +4 lines, -1 line 0 comments Download
M src/net/hosts.go View 1 2 chunks +3 lines, -3 lines 0 comments Download
M src/net/hosts_test.go View 1 2 chunks +6 lines, -6 lines 0 comments Download
M src/net/lookup_unix.go View 1 1 chunk +4 lines, -1 line 0 comments Download
M src/net/port_unix.go View 1 1 chunk +4 lines, -1 line 0 comments Download

Messages

Total messages: 10
oneofone
Hello golang-codereviews@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go
9 years, 9 months ago (2014-09-17 22:36:37 UTC) #1
0xjnml
On 2014/09/17 22:36:37, oneofone wrote: > Hello mailto:golang-codereviews@googlegroups.com, > > I'd like you to review ...
9 years, 9 months ago (2014-09-18 08:40:35 UTC) #2
oneofone
On 2014/09/18 08:40:35, 0xjnml wrote: > On 2014/09/17 22:36:37, oneofone wrote: > > Hello mailto:golang-codereviews@googlegroups.com, ...
9 years, 9 months ago (2014-09-18 12:41:44 UTC) #3
iant
It sounds like, in Go terms, this varies only based on GOOS, so it seems ...
9 years, 9 months ago (2014-09-18 18:25:21 UTC) #4
oneofone
Besides android and my nameless cheap Chinese router, not that I'm aware of. But the ...
9 years, 9 months ago (2014-09-18 19:19:32 UTC) #5
iant
On Thu, Sep 18, 2014 at 12:19 PM, Ahmed Waheed <oneofone@gmail.com> wrote: > Besides android ...
9 years, 9 months ago (2014-09-18 19:44:13 UTC) #6
rsc
NOT LGTM These are Unix details leaking into the public API of the not-Unix-specific net ...
9 years, 9 months ago (2014-09-25 18:29:56 UTC) #7
gobot
R=close To the author of this CL: The Go project has moved to Gerrit Code ...
9 years, 6 months ago (2014-12-19 05:13:22 UTC) #8
federienzo
On 2014/09/25 18:29:56, rsc wrote: > NOT LGTM > > These are Unix details leaking ...
2 weeks, 5 days ago (2024-06-05 06:18:06 UTC) #9
federienzo
2 weeks, 5 days ago (2024-06-05 06:20:30 UTC) #10
On 2014/09/25 18:29:56, rsc wrote:
> NOT LGTM
> 
> These are Unix details leaking into the public API of the not-Unix-specific
net
> package.
> 
> And certainly not at this stage in the release cycle.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b