Issue 14216044: Enable dropping a bundle token to deploy.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 14216044: Enable dropping a bundle token to deploy.

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 7 months ago by benji

Modified:
10 years, 7 months ago

Reviewers:
jeff.pihach, mp+188683

Visibility:
Public.

Description

Enable dropping a bundle token to deploy. https://code.launchpad.net/~benji/juju-gui/make-deploying-bundles-work/+merge/188683 (do not edit description out of merge proposal)

Patch Set 2 : Enable dropping a bundle token to deploy. #

Patch Set 3 : Enable dropping a bundle token to deploy. #

Created: 10 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+80 lines, -32 lines)			Patch
A	[revision details]	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download
M	app/store/env/fakebackend.js	View		1 chunk	+1 line, -1 line	0 comments	Download
M	app/views/topology/service.js	View		4 chunks	+20 lines, -12 lines	0 comments	Download
M	app/views/utils.js	View	1	1 chunk	+21 lines, -0 lines	0 comments	Download
M	app/widgets/token.js	View		3 chunks	+3 lines, -12 lines	0 comments	Download
M	test/test_fakebackend.js	View		1 chunk	+1 line, -1 line	0 comments	Download
M	test/test_sandbox_go.js	View		1 chunk	+1 line, -1 line	0 comments	Download
M	test/test_service_module.js	View		3 chunks	+31 lines, -5 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

jeff.pihach

LGTM with trivial, Thanks! https://codereview.appspot.com/14216044/diff/1/app/views/utils.js File app/views/utils.js (right): https://codereview.appspot.com/14216044/diff/1/app/views/utils.js#newcode1632 app/views/utils.js:1632: utils.determineEntityDataType = function(tokenData) { add ...

10 years, 7 months ago (2013-10-01 18:50:33 UTC) #2

benji

Thanks for the review. https://codereview.appspot.com/14216044/diff/1/app/views/utils.js File app/views/utils.js (right): https://codereview.appspot.com/14216044/diff/1/app/views/utils.js#newcode1632 app/views/utils.js:1632: utils.determineEntityDataType = function(tokenData) { On ...

10 years, 7 months ago (2013-10-01 19:15:32 UTC) #3

benji

10 years, 7 months ago (2013-10-01 19:38:20 UTC) #4

*** Submitted:

Enable dropping a bundle token to deploy.

R=jeff.pihach
CC=
https://codereview.appspot.com/14216044

Expand All Messages | Collapse All Messages