code review 14203043: freetype/truetype: make a (sub-)glyph's points an expli...

freetype/truetype: make a (sub-)glyph's points an explicit part of a
Hinter's state, instead of having a glyph shrink and restore its
points around hinting.

[nigeltao, 2013-10-01 12:13:43]

Hello bsiegert@gmail.com (cc: golang-dev@googlegroups.com),

I'd like you to review this change to
https://code.google.com/p/freetype-go

[bsiegert, 2013-10-01 14:02:00]

LGTM

https://codereview.appspot.com/14203043/diff/5001/freetype/truetype/glyph.go
File freetype/truetype/glyph.go (right):

https://codereview.appspot.com/14203043/diff/5001/freetype/truetype/glyph.go#...
freetype/truetype/glyph.go:278: err := h.run(
Put the call on one line.

https://codereview.appspot.com/14203043/diff/5001/freetype/truetype/hint.go
File freetype/truetype/hint.go (right):

https://codereview.appspot.com/14203043/diff/5001/freetype/truetype/hint.go#n...
freetype/truetype/hint.go:16: twilightZone = 0
Use iota instead of explicit values?

Same below.

https://codereview.appspot.com/14203043/diff/5001/freetype/truetype/hint.go#n...
freetype/truetype/hint.go:18: nZone        = 2
s/n/num/ for clarity?

[nigeltao, 2013-10-02 10:36:06]

https://codereview.appspot.com/14203043/diff/5001/freetype/truetype/glyph.go
File freetype/truetype/glyph.go (right):

https://codereview.appspot.com/14203043/diff/5001/freetype/truetype/glyph.go#...
freetype/truetype/glyph.go:278: err := h.run(
On 2013/10/01 14:02:00, bsiegert wrote:
> Put the call on one line.

Done.

https://codereview.appspot.com/14203043/diff/5001/freetype/truetype/hint.go
File freetype/truetype/hint.go (right):

https://codereview.appspot.com/14203043/diff/5001/freetype/truetype/hint.go#n...
freetype/truetype/hint.go:16: twilightZone = 0
On 2013/10/01 14:02:00, bsiegert wrote:
> Use iota instead of explicit values?

I'd rather use explicit values here. The values aren't arbitrary. For example,
https://developer.apple.com/fonts/TTRefMan/RM02/Chap2.html#zones_points says
that the twilight zone is specifically zone 0.

https://codereview.appspot.com/14203043/diff/5001/freetype/truetype/hint.go#n...
freetype/truetype/hint.go:18: nZone        = 2
On 2013/10/01 14:02:00, bsiegert wrote:
> s/n/num/ for clarity?

Done.

[nigeltao, 2013-10-02 10:37:22]

*** Submitted as
https://code.google.com/p/freetype-go/source/detail?r=1acc6d57c87a ***

freetype/truetype: make a (sub-)glyph's points an explicit part of a
Hinter's state, instead of having a glyph shrink and restore its
points around hinting.

R=bsiegert
CC=golang-dev
https://codereview.appspot.com/14203043