Prevent stacking of services recv'd from delta

Prevent stacking of services recv'd from delta

Services recieved from delta singly are placed one atop the other.  This defaults to placing them on the standard point outside used for creating services one by one in the GUI.

https://code.launchpad.net/~makyo/juju-gui/position-from-cli-1214821/+merge/189404

(do not edit description out of merge proposal)

[matthew.scott, 2013-10-04 18:46:03]

Please take a look.

[jeff.pihach, 2013-10-04 19:27:22]

LGTM Thanks for this fix - trivial comments.

https://codereview.appspot.com/14181044/diff/1/app/views/topology/service.js
File app/views/topology/service.js (right):

https://codereview.appspot.com/14181044/diff/1/app/views/topology/service.js#...
app/views/topology/service.js:1075: service.x += pointOutside[0] - service.x;
I'm guessing this needs to be done in the model as well for the delta? Can you
add a note to that effect.

https://codereview.appspot.com/14181044/diff/1/app/views/topology/topology.js
File app/views/topology/topology.js (right):

https://codereview.appspot.com/14181044/diff/1/app/views/topology/topology.js...
app/views/topology/topology.js:183: return box.x !== undefined &&
!isNaN(box.center[0]);
Take a look at the final 'false positive' example on the following link - can we
ever get a string here?

https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Obje...

[matthew.scott, 2013-10-04 21:09:58]

Thanks for the review.

https://codereview.appspot.com/14181044/diff/1/app/views/topology/service.js
File app/views/topology/service.js (right):

https://codereview.appspot.com/14181044/diff/1/app/views/topology/service.js#...
app/views/topology/service.js:1075: service.x += pointOutside[0] - service.x;
On 2013/10/04 19:27:22, jeff.pihach wrote:
> I'm guessing this needs to be done in the model as well for the delta? Can you
> add a note to that effect.

No, only annotations are stored in the model, which is done after this addition.
 However, I will add a comment to this.

https://codereview.appspot.com/14181044/diff/1/app/views/topology/topology.js
File app/views/topology/topology.js (right):

https://codereview.appspot.com/14181044/diff/1/app/views/topology/topology.js...
app/views/topology/topology.js:183: return box.x !== undefined &&
!isNaN(box.center[0]);
On 2013/10/04 19:27:22, jeff.pihach wrote:
> Take a look at the final 'false positive' example on the following link - can
we
> ever get a string here?
> 
>
https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Obje...

I don't believe so, and even the literal NaN results are an artifact of the test
framework setting up incomplete topologies, rather than any real scenario from a
delta.

[matthew.scott, 2013-10-04 21:20:01]

*** Submitted:

Prevent stacking of services recv'd from delta

Services recieved from delta singly are placed one atop the other.  This
defaults to placing them on the standard point outside used for creating
services one by one in the GUI.

R=jeff.pihach
CC=
https://codereview.appspot.com/14181044