Normalize charm view for bundles

Normalize charm view for bundles

This should have no user facing changes, just a
reorg of the code.

https://code.launchpad.net/~hatch/juju-gui/normalize-charm-view/+merge/188887

(do not edit description out of merge proposal)

[jeff.pihach, 2013-10-02 16:48:41]

Please take a look.

[jeff.pihach, 2013-10-02 16:55:07]

reviewer comments

https://codereview.appspot.com/14175046/diff/1/app/subapps/browser/views/char...
File app/subapps/browser/views/charm.js (left):

https://codereview.appspot.com/14175046/diff/1/app/subapps/browser/views/char...
app/subapps/browser/views/charm.js:99: * Shared method to generate a message to
the user based on a bad api
moved to entity-base.js

https://codereview.appspot.com/14175046/diff/1/app/subapps/browser/views/char...
app/subapps/browser/views/charm.js:388: * Load the charm's QA data and fill it
into the tab when selected.
moved to entity-base.js

https://codereview.appspot.com/14175046/diff/1/app/subapps/browser/views/char...
app/subapps/browser/views/charm.js:787: ATTRS: {
moved to entity-base.js

https://codereview.appspot.com/14175046/diff/1/app/subapps/browser/views/enti...
File app/subapps/browser/views/entity-base.js (right):

https://codereview.appspot.com/14175046/diff/1/app/subapps/browser/views/enti...
app/subapps/browser/views/entity-base.js:1: /*
almost entirely moved from charm.js

[rharding, 2013-10-02 17:04:33]

Code is ok with comments below. Will do qa next.

https://codereview.appspot.com/14175046/diff/1/app/subapps/browser/browser.js
File app/subapps/browser/browser.js (right):

https://codereview.appspot.com/14175046/diff/1/app/subapps/browser/browser.js...
app/subapps/browser/browser.js:526: var charmId = this._viewState.charmID;
should this update then as well to entityId?

https://codereview.appspot.com/14175046/diff/1/app/subapps/browser/browser.js...
app/subapps/browser/browser.js:550: var model =
this._cache.charms.getById(charmId);
and if this is a bundle this is meant to just always miss the cache right now?

https://codereview.appspot.com/14175046/diff/1/app/subapps/browser/views/char...
File app/subapps/browser/views/charm.js (right):

https://codereview.appspot.com/14175046/diff/1/app/subapps/browser/views/char...
app/subapps/browser/views/charm.js:85: var Charm = this.get('entity'),
don't cap the variable. That's for Classes, not instances. it would just be
charm.

https://codereview.appspot.com/14175046/diff/1/test/test_browser_charm_detail...
File test/test_browser_charm_details.js (right):

https://codereview.appspot.com/14175046/diff/1/test/test_browser_charm_detail...
test/test_browser_charm_details.js:338: var serviceCharm = view.get('entity');
why the change to serviceCharm? What is a serviceCharm? There's not the idea of
a service in the browser codebase really.

[rharding, 2013-10-02 17:07:46]

QA not ok, opening the charm details view from the inspector no longer works. 

There's an issue with the id.

[jeff.pihach, 2013-10-02 17:14:42]

Thanks for the review & QA! Comments below and I'll investigate the QA failure.

https://codereview.appspot.com/14175046/diff/1/app/subapps/browser/browser.js
File app/subapps/browser/browser.js (right):

https://codereview.appspot.com/14175046/diff/1/app/subapps/browser/browser.js...
app/subapps/browser/browser.js:526: var charmId = this._viewState.charmID;
I had it as entityId but then changed it to charmId because that's what it is -
I imagine this will be changed throughout the app to entityId but that rabbit
hole went pretty deep so I didn't want to do that in this branch.

https://codereview.appspot.com/14175046/diff/1/app/subapps/browser/browser.js...
app/subapps/browser/browser.js:550: var model =
this._cache.charms.getById(charmId);
ATM this branch does nothing with bundles - I would imagine we would add the
caching in with the bundle or shortly thereafter

https://codereview.appspot.com/14175046/diff/1/app/subapps/browser/views/char...
File app/subapps/browser/views/charm.js (right):

https://codereview.appspot.com/14175046/diff/1/app/subapps/browser/views/char...
app/subapps/browser/views/charm.js:85: var Charm = this.get('entity'),
oops typo, fixed.

https://codereview.appspot.com/14175046/diff/1/test/test_browser_charm_detail...
File test/test_browser_charm_details.js (right):

https://codereview.appspot.com/14175046/diff/1/test/test_browser_charm_detail...
test/test_browser_charm_details.js:338: var serviceCharm = view.get('entity');
ehh I just felt it more appropriate because we no longer have a browserCharm

[jeff.pihach, 2013-10-02 17:49:16]

Please take a look.

[rharding, 2013-10-02 17:58:53]

LGTM QA ok, thanks for the update.

[jeff.pihach, 2013-10-02 18:00:53]

Thanks for the review and multi-qa :)

[jeff.pihach, 2013-10-02 18:09:50]

*** Submitted:

Normalize charm view for bundles

This should have no user facing changes, just a
reorg of the code.

R=rharding
CC=
https://codereview.appspot.com/14175046