Issue 14174043: code review 14174043: cmd/go: use -installsuffix to determine the includes di...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 14174043: code review 14174043: cmd/go: use -installsuffix to determine the includes di... (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 7 months ago by djd

Modified:
11 years, 7 months ago

Reviewers:
adg, rsc

CC:
adg, rsc, golang-dev

Visibility:
Public.

Description

cmd/go: use -installsuffix to determine the includes directory list Currently, the directories generaed by includeArgs can have the "_race" suffix added if invoked with -race flag, but ignores -installsuffix if set.

Patch Set 1 #

Patch Set 2 : diff -r 8119adb1b8d1 https://code.google.com/p/go #

Patch Set 3 : diff -r 8119adb1b8d1 https://code.google.com/p/go #

Created: 11 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -2 lines)			Patch
	M	src/cmd/go/build.go	View	1	1 chunk	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

djd

Hello adg@golang.org, rsc@golang.org (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go

11 years, 7 months ago (2013-10-01 01:13:34 UTC) #1

rsc

11 years, 7 months ago (2013-10-02 00:45:07 UTC) #5

*** Submitted as https://code.google.com/p/go/source/detail?r=2ec3da6e74e4 ***

cmd/go: use -installsuffix to determine the includes directory list

Currently, the directories generaed by includeArgs can have the "_race"
suffix added if invoked with -race flag, but ignores -installsuffix if
set.

R=adg, rsc
CC=golang-dev
https://codereview.appspot.com/14174043

Committer: Russ Cox <rsc@golang.org>

Expand All Messages | Collapse All Messages