Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(3599)

Issue 14171043: code review 14171043: misc/vim: Separate package and package members.

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 7 months ago by mattn
Modified:
10 years, 7 months ago
Reviewers:
dsymonds
CC:
golang-dev, dsymonds
Visibility:
Public.

Description

misc/vim: Separate package and package members. This change allow to godoc: :Godoc github.com/mattn/go-gtk/gtk :Godoc github.com/mattn/go-gtk/gtk NewWindow :Godoc encoding/json :Godoc encoding/json Marshal

Patch Set 1 #

Patch Set 2 : diff -r 8119adb1b8d1 http://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 8119adb1b8d1 http://go.googlecode.com/hg/ #

Patch Set 4 : diff -r 8119adb1b8d1 http://go.googlecode.com/hg/ #

Patch Set 5 : diff -r 8119adb1b8d1 http://go.googlecode.com/hg/ #

Patch Set 6 : diff -r 8119adb1b8d1 http://go.googlecode.com/hg/ #

Patch Set 7 : diff -r 8119adb1b8d1 http://go.googlecode.com/hg/ #

Patch Set 8 : diff -r 8119adb1b8d1 http://go.googlecode.com/hg/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -16 lines) Patch
M misc/vim/autoload/go/complete.vim View 1 2 3 4 5 6 7 1 chunk +6 lines, -0 lines 0 comments Download
M misc/vim/plugin/godoc.vim View 1 2 3 4 5 6 4 chunks +20 lines, -16 lines 0 comments Download

Messages

Total messages: 10
mattn
Hello golang-dev@googlegroups.com, I'd like you to review this change to http://go.googlecode.com/hg/
10 years, 7 months ago (2013-10-01 00:11:20 UTC) #1
dsymonds
We went through this in https://codereview.appspot.com/10564043/. Can we make it so invoking :Godoc with any ...
10 years, 7 months ago (2013-10-01 00:18:35 UTC) #2
mattn
On 2013/10/01 00:18:35, dsymonds wrote: > We went through this in https://codereview.appspot.com/10564043/. Can we make ...
10 years, 7 months ago (2013-10-01 00:22:50 UTC) #3
dsymonds
LGTM I'll submit this tomorrow unless someone else yells.
10 years, 7 months ago (2013-10-01 00:34:20 UTC) #4
mattn
On 2013/10/01 00:34:20, dsymonds wrote: > LGTM > > I'll submit this tomorrow unless someone ...
10 years, 7 months ago (2013-10-01 00:44:35 UTC) #5
mattn
On 2013/10/01 00:44:35, mattn wrote: > On 2013/10/01 00:34:20, dsymonds wrote: > > LGTM > ...
10 years, 7 months ago (2013-10-01 01:56:03 UTC) #6
dsymonds
please stop adding features to this CL. Revert it back to what I LGTM'd and ...
10 years, 7 months ago (2013-10-01 02:01:07 UTC) #7
mattn
On 2013/10/01 02:01:07, dsymonds wrote: > please stop adding features to this CL. Revert it ...
10 years, 7 months ago (2013-10-01 02:02:45 UTC) #8
mattn
On 2013/10/01 02:02:45, mattn wrote: > On 2013/10/01 02:01:07, dsymonds wrote: > > please stop ...
10 years, 7 months ago (2013-10-01 02:08:00 UTC) #9
dsymonds
10 years, 7 months ago (2013-10-01 22:52:57 UTC) #10
*** Submitted as https://code.google.com/p/go/source/detail?r=b3cd4b6ed776 ***

misc/vim: Separate package and package members.
This change allow to godoc:
    :Godoc github.com/mattn/go-gtk/gtk
    :Godoc github.com/mattn/go-gtk/gtk NewWindow
    :Godoc encoding/json
    :Godoc encoding/json Marshal

R=golang-dev, dsymonds
CC=golang-dev
https://codereview.appspot.com/14171043

Committer: David Symonds <dsymonds@golang.org>
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b