Issue 14169044: code review 14169044: go.tools/go/types: more flexible error checking

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 14169044: code review 14169044: go.tools/go/types: more flexible error checking (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 1 month ago by gri

Modified:
12 years, 1 month ago

Reviewers:
adonovan

CC:
adonovan, golang-dev

Visibility:
Public.

Description

go.tools/go/types: more flexible error checking - permit ERROR markers to be in full or line comments - don't require ""s in /* ERROR "foo" */ - enable more std tests - some minor cleanups

Patch Set 2 : diff -r 289f8340048e https://code.google.com/p/go.tools #

Patch Set 3 : diff -r 289f8340048e https://code.google.com/p/go.tools #

Patch Set 4 : diff -r 289f8340048e https://code.google.com/p/go.tools #

Patch Set 5 : diff -r 289f8340048e https://code.google.com/p/go.tools #

Total comments: 1

Patch Set 6 : diff -r 3afab15d549e https://code.google.com/p/go.tools #

Created: 12 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+19 lines, -9 lines)			Patch
M	go/types/check_test.go	View	1 2 3	2 chunks	+9 lines, -5 lines	0 comments	Download
M	go/types/stdlib_test.go	View	1	1 chunk	+0 lines, -1 line	0 comments	Download
M	go/types/testdata/errors.src	View	1 2 3	1 chunk	+8 lines, -0 lines	0 comments	Download
M	go/types/testdata/expr0.src	View	1 2	2 chunks	+2 lines, -2 lines	0 comments	Download
M	go/types/typexpr.go	View	1	1 chunk	+0 lines, -1 line	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

gri

Hello adonovan@google.com (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go.tools

12 years, 1 month ago (2013-10-01 01:11:51 UTC) #1

adonovan

LGTM https://codereview.appspot.com/14169044/diff/11001/go/types/check_test.go File go/types/check_test.go (right): https://codereview.appspot.com/14169044/diff/11001/go/types/check_test.go#newcode113 go/types/check_test.go:113: // ERROR comments must start with text `ERROR ...

12 years, 1 month ago (2013-10-01 02:24:07 UTC) #2

gri

12 years, 1 month ago (2013-10-01 04:47:45 UTC) #3

*** Submitted as
https://code.google.com/p/go/source/detail?r=cc9b5c2d3739&repo=tools ***

go.tools/go/types: more flexible error checking

- permit ERROR markers to be in full or line comments
- don't require ""s in /* ERROR "foo" */
- enable more std tests
- some minor cleanups

R=adonovan
CC=golang-dev
https://codereview.appspot.com/14169044

Expand All Messages | Collapse All Messages