code review 141510044: cmd/gc: say 'non-constant array bound' instead of 'inva...

cmd/gc: say 'non-constant array bound' instead of 'invalid array bound'

Fixes issue 8196.

[rsc, 2014-09-15 18:10:37]

Hello adonovan (cc: golang-codereviews@googlegroups.com),

I'd like you to review this change to
https://code.google.com/p/go/

[adonovan, 2014-09-15 18:21:26]

LGTM

thanks


On 15 September 2014 14:10, <rsc@golang.org> wrote:

> Reviewers: adonovan,
>
> Message:
> Hello adonovan (cc: golang-codereviews@googlegroups.com),
>
> I'd like you to review this change to
> https://code.google.com/p/go/
>
>
> Description:
> cmd/gc: say 'non-constant array bound' instead of 'invalid array bound'
>
> Fixes issue 8196.
>
> Please review this at https://codereview.appspot.com/141510044/
>
> Affected files (+1, -1 lines):
>   M src/cmd/gc/typecheck.c
>
>
> Index: src/cmd/gc/typecheck.c
> ===================================================================
> --- a/src/cmd/gc/typecheck.c
> +++ b/src/cmd/gc/typecheck.c
> @@ -408,7 +408,7 @@
>                                 v = toint(l->val);
>                                 break;
>                         default:
> -                               yyerror("invalid array bound %N", l);
> +                               yyerror("non-constant array bound %N", l);
>                                 goto error;
>                         }
>                         t->bound = mpgetfix(v.u.xval);
>
>
>

[rsc, 2014-09-16 14:21:57]

*** Submitted as https://code.google.com/p/go/source/detail?r=29d347a2b827 ***

cmd/gc: say 'non-constant array bound' instead of 'invalid array bound'

Fixes issue 8196.

LGTM=adonovan
R=adonovan
CC=golang-codereviews
https://codereview.appspot.com/141510044