Issue 14136043: environs: add store arg to NewFromName etc

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 7 months ago by rog

Modified:
10 years, 7 months ago

Reviewers:
axw1, mp+188409

Visibility:
Public.

Description

environs: add store arg to NewFromName etc This enables us to delete the EnsureCACert magic. Old certificates should still be used, as the old config magic will still read them. https://code.launchpad.net/~rogpeppe/juju-core/426-environs-add-store-to-new/+merge/188409 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : environs: add store arg to NewFromName etc #

Patch Set 3 : environs: add store arg to NewFromName etc #

Total comments: 2

Patch Set 4 : environs: add store arg to NewFromName etc #

Patch Set 5 : environs: add store arg to NewFromName etc #

Created: 10 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+185 lines, -281 lines)			Patch
A	[revision details]	View	1 2 3 4	1 chunk	+2 lines, -0 lines	0 comments	Download
M	cmd/juju/bootstrap.go	View		1 chunk	+0 lines, -5 lines	0 comments	Download
M	cmd/juju/bootstrap_test.go	View		1 chunk	+3 lines, -1 line	0 comments	Download
M	cmd/juju/cmd_test.go	View		1 chunk	+1 line, -1 line	0 comments	Download
M	cmd/juju/destroyenvironment.go	View		1 chunk	+2 lines, -6 lines	0 comments	Download
M	cmd/juju/endpoint.go	View		2 chunks	+9 lines, -6 lines	0 comments	Download
M	cmd/juju/synctools_test.go	View		6 chunks	+11 lines, -8 lines	0 comments	Download
M	cmd/plugins/juju-metadata/validateimagemetadata.go	View		2 chunks	+6 lines, -1 line	0 comments	Download
M	cmd/plugins/juju-metadata/validatetoolsmetadata.go	View		2 chunks	+6 lines, -1 line	0 comments	Download
D	environs/cert.go	View		1 chunk	+0 lines, -79 lines	0 comments	Download
D	environs/cert_internal_test.go	View		1 chunk	+0 lines, -52 lines	0 comments	Download
D	environs/cert_test.go	View		1 chunk	+0 lines, -93 lines	0 comments	Download
M	environs/open.go	View	1 2	6 chunks	+79 lines, -19 lines	0 comments	Download
M	environs/open_test.go	View	1 2	6 chunks	+53 lines, -7 lines	0 comments	Download
M	juju/conn.go	View	1 2 3 4	2 chunks	+6 lines, -1 line	0 comments	Download
M	provider/dummy/storage.go	View		1 chunk	+6 lines, -0 lines	0 comments	Download
M	worker/uniter/uniter.go	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 6

Expand All Messages | Collapse All Messages

axw1

LGTM, possibly with below. https://codereview.appspot.com/14136043/diff/6001/juju/conn.go File juju/conn.go (right): https://codereview.appspot.com/14136043/diff/6001/juju/conn.go#newcode123 juju/conn.go:123: store, err := configstore.NewDisk(config.JujuHome()) Should ...

10 years, 7 months ago (2013-10-01 07:43:03 UTC) #3

rog

https://codereview.appspot.com/14136043/diff/6001/juju/conn.go File juju/conn.go (right): https://codereview.appspot.com/14136043/diff/6001/juju/conn.go#newcode123 juju/conn.go:123: store, err := configstore.NewDisk(config.JujuHome()) On 2013/10/01 07:43:03, axw1 wrote: ...

10 years, 7 months ago (2013-10-01 15:56:30 UTC) #5

Please take a look.

Expand All Messages | Collapse All Messages