Issue 141330043: code review 141330043: reflect: use runtime's memmove instead of its own

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 141330043: code review 141330043: reflect: use runtime's memmove instead of its own (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 7 months ago by khr

Modified:
10 years, 7 months ago

Reviewers:
rsc

CC:
golang-codereviews, rsc

Visibility:
Public.

Description

reflect: use runtime's memmove instead of its own They will both need write barriers at some point. But until then, no reason why we shouldn't share.

Patch Set 1 #

Patch Set 2 : diff -r 327fbd1800e393b29f1325c6e3ed97c07f71578a https://khr%40golang.org@code.google.com/p/go/ #

Patch Set 3 : diff -r 0eda065231ddc227a5f7ac9bb2aeed9259f8966f https://khr%40golang.org@code.google.com/p/go/ #

Patch Set 4 : diff -r ca2c8c76aed9059b73eac0a8986bf84e6f10f8b5 https://khr%40golang.org@code.google.com/p/go/ #

Created: 10 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -26 lines)			Patch
	M	src/reflect/value.go	View	1	2 chunks	+3 lines, -26 lines	0 comments	Download
	M	src/runtime/thunk.s	View	1	1 chunk	+3 lines, -0 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

khr

Hello golang-codereviews@googlegroups.com, I'd like you to review this change to https://khr%40golang.org@code.google.com/p/go/

10 years, 7 months ago (2014-09-09 21:36:01 UTC) #1

khr

10 years, 7 months ago (2014-09-10 19:37:31 UTC) #3

*** Submitted as https://code.google.com/p/go/source/detail?r=769430bdffb7 ***

reflect: use runtime's memmove instead of its own

They will both need write barriers at some point.
But until then, no reason why we shouldn't share.

LGTM=rsc
R=golang-codereviews, rsc
CC=golang-codereviews
https://codereview.appspot.com/141330043

Expand All Messages | Collapse All Messages