Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1656)

Issue 14125043: Units and constraints handling in subordinates.

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 6 months ago by frankban
Modified:
10 years, 6 months ago
Reviewers:
mp+188339, jeff.pihach
Visibility:
Public.

Description

Units and constraints handling in subordinates. Improve how unit scaling and constraint options are handled in the ghost and deployed inspectors when a service is deployed from a subordinate charm. Also fixed a bug in the units count preventing subordinates to be deployed in a juju-core sandbox/real environment. QA: - make devel/debug; - deploy a principal charm, both the ghost inspector and the deployed inspector include unit scaling and constraints, everything works as expected; - deploy a subordinate charm (e.g. puppet), inspectors don't show unit scaling and constraints, everything works as expected. https://code.launchpad.net/~frankban/juju-gui/subordinate-inspector/+merge/188339 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : Units and constraints handling in subordinates. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+94 lines, -40 lines) Patch
A [revision details] View 1 chunk +2 lines, -0 lines 0 comments Download
M app/templates/ghost-config-viewlet.handlebars View 1 chunk +1 line, -1 line 0 comments Download
M app/templates/service-config-wrapper.handlebars View 2 chunks +2 lines, -0 lines 0 comments Download
M app/templates/serviceOverview.handlebars View 1 chunk +17 lines, -15 lines 0 comments Download
M app/views/environment.js View 1 chunk +3 lines, -1 line 0 comments Download
M app/views/ghost-inspector.js View 1 chunk +1 line, -1 line 0 comments Download
M app/views/viewlets/service-ghost.js View 1 chunk +15 lines, -15 lines 0 comments Download
M test/test_ghost_inspector.js View 6 chunks +28 lines, -3 lines 0 comments Download
M test/test_inspector_overview.js View 4 chunks +25 lines, -4 lines 0 comments Download

Messages

Total messages: 4
frankban
Please take a look.
10 years, 6 months ago (2013-09-30 13:54:51 UTC) #1
jeff.pihach
LGTM Thanks for this! QA OK
10 years, 6 months ago (2013-09-30 15:55:55 UTC) #2
frankban
*** Submitted: Units and constraints handling in subordinates. Improve how unit scaling and constraint options ...
10 years, 6 months ago (2013-09-30 16:04:24 UTC) #3
frankban
10 years, 6 months ago (2013-09-30 16:18:18 UTC) #4
Hey Jeff, thanks for the review!
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b