Issue 141190043: Check for Note_column interface before using grob. (Closed)
DescriptionCheck for Note_column interface before using grob.
Rest_collision was calling Note_column functions on grobs that did not
have the Note_column interface. Now Rest_collision ignores such grobs
and Note_column will print a more accurate message if such an error
ever happens again.
Reported in
http://article.gmane.org/gmane.comp/gnu.lilypond.bugs/39758 .
Patch Set 1 #
Total comments: 1
Patch Set 2 : fixed indentation #
MessagesTotal messages: 14
Logged on issue tracker as Issue 4094: Note_column programming errors
Sign in to reply to this message.
LGTM (from a quick look).
Sign in to reply to this message.
LGTM https://codereview.appspot.com/141190043/diff/1/lily/rest-collision.cc File lily/rest-collision.cc (right): https://codereview.appspot.com/141190043/diff/1/lily/rest-collision.cc#newcod... lily/rest-collision.cc:111: if (Note_column::has_interface(e)) We'll run this through the 'fixcc.py' code formatter at some point, keeping things consistent with the (admittedly odd) GNU style.
Sign in to reply to this message.
On 2014/09/07 06:23:08, Keith wrote: > LGTM > > https://codereview.appspot.com/141190043/diff/1/lily/rest-collision.cc > File lily/rest-collision.cc (right): > > https://codereview.appspot.com/141190043/diff/1/lily/rest-collision.cc#newcod... > lily/rest-collision.cc:111: if (Note_column::has_interface(e)) > We'll run this through the 'fixcc.py' code formatter at some point, keeping > things consistent with the (admittedly odd) GNU style. It's better to follow the style right away when feasible since it makes for nicer histories when calling "git blame" and its ilk.
Sign in to reply to this message.
On 2014/09/07 06:58:30, dak wrote: > It's better to follow the style right away when feasible since it makes for > nicer histories when calling "git blame" and its ilk. Yes, I'll do that. Sorry I haven't read through the whole CG.
Sign in to reply to this message.
Indentation is fixed.
Sign in to reply to this message.
Dan, just note that this patch has had no testing whatsover. At this time it is just a Rietveld review so won't be considered for pushing to git. I will manually update the tracker issue for this, but please make sure that if you do any updates to an issue that you also update the tracker so the automatic test tools catch the patch. It was only because I was randomly browsing my emails that I caught this. We don't want someone's hard work to be wasted. James
Sign in to reply to this message.
On Sep 9, 2014, at 06:27 , pkx166h@gmail.com wrote: > I will manually update the tracker issue for this, but please make sure > that if you do any updates to an issue that you also update the tracker > so the automatic test tools catch the patch. It was only because I was > randomly browsing my emails that I caught this. We don't want someone's > hard work to be wasted. Thank you. eble@ticalc.org was working for some Google services, but not Google Code. I created a new account (nine.fierce.ballads@gmail.com) that I will use for future work. The tracker shows that I’m logged in, so hopefully the automated notification will work next time. — Dan
Sign in to reply to this message.
----- Original Message ----- From: "Dan Eble" <dan@faithful.be> To: "Daniel Eble" <eble@ticalc.org>; <colinpkcampbell@gmail.com>; "Janek Warchol" <janek.lilypond@gmail.com>; "Keith OHara" <k-ohara5a5a@oco.net>; "David Kastrup" <dak@gnu.org>; "James" <pkx166h@gmail.com>; "Developers List" <lilypond-devel@gnu.org>; <reply@codereview-hr.appspotmail.com> Sent: Wednesday, September 10, 2014 5:02 AM Subject: Re: Check for Note_column interface before using grob. (issue141190043 by eble@ticalc.org) On Sep 9, 2014, at 06:27 , pkx166h@gmail.com wrote: > I will manually update the tracker issue for this, but please make sure > that if you do any updates to an issue that you also update the tracker > so the automatic test tools catch the patch. It was only because I was > randomly browsing my emails that I caught this. We don't want someone's > hard work to be wasted. Thank you. eble@ticalc.org was working for some Google services, but not Google Code. I created a new account (nine.fierce.ballads@gmail.com) that I will use for future work. The tracker shows that I’m logged in, so hopefully the automated notification will work next time. — Dan _______________________________________________ I believe that you need to be registered as a developer on our Issues tracker to create issues using git-cl. I can do this for you if you let me know which Google account you want to use. -- Phil Holmes
Sign in to reply to this message.
Dan Eble <dan@faithful.be> writes: > On Sep 9, 2014, at 06:27 , pkx166h@gmail.com wrote: > >> I will manually update the tracker issue for this, but please make sure >> that if you do any updates to an issue that you also update the tracker >> so the automatic test tools catch the patch. It was only because I was >> randomly browsing my emails that I caught this. We don't want someone's >> hard work to be wasted. > > Thank you. eble@ticalc.org was working for some Google services, but > not Google Code. I created a new account > (nine.fierce.ballads@gmail.com) that I will use for future work. The > tracker shows that I’m logged in, so hopefully the automated > notification will work next time. Well, if you take a look at the copied Email addresses in your mail, you'll find that Keith and myself get along without a Gmail account. -- David Kastrup
Sign in to reply to this message.
----- Original Message ----- From: "David Kastrup" <dak@gnu.org> To: "Dan Eble" <dan@faithful.be> Cc: "Keith OHara" <k-ohara5a5a@oco.net>; <reply@codereview-hr.appspotmail.com>; <colinpkcampbell@gmail.com>; "Daniel Eble" <eble@ticalc.org>; "Developers List" <lilypond-devel@gnu.org> Sent: Wednesday, September 10, 2014 7:07 AM Subject: Re: Check for Note_column interface before using grob. (issue141190043 by eble@ticalc.org) > Dan Eble <dan@faithful.be> writes: > >> On Sep 9, 2014, at 06:27 , pkx166h@gmail.com wrote: >> >>> I will manually update the tracker issue for this, but please make sure >>> that if you do any updates to an issue that you also update the tracker >>> so the automatic test tools catch the patch. It was only because I was >>> randomly browsing my emails that I caught this. We don't want someone's >>> hard work to be wasted. >> >> Thank you. eble@ticalc.org was working for some Google services, but >> not Google Code. I created a new account >> (nine.fierce.ballads@gmail.com) that I will use for future work. The >> tracker shows that I’m logged in, so hopefully the automated >> notification will work next time. > > Well, if you take a look at the copied Email addresses in your mail, > you'll find that Keith and myself get along without a Gmail account. > > -- > David Kastrup I was under the impression that you had a Google account, but not a Google email address? -- Phil Holmes
Sign in to reply to this message.
"Phil Holmes" <mail@philholmes.net> writes: > ----- Original Message ----- > From: "David Kastrup" <dak@gnu.org> > To: "Dan Eble" <dan@faithful.be> > Cc: "Keith OHara" <k-ohara5a5a@oco.net>; > <reply@codereview-hr.appspotmail.com>; <colinpkcampbell@gmail.com>; > "Daniel Eble" <eble@ticalc.org>; "Developers List" > <lilypond-devel@gnu.org> > Sent: Wednesday, September 10, 2014 7:07 AM > Subject: Re: Check for Note_column interface before using > grob. (issue141190043 by eble@ticalc.org) > > >> Dan Eble <dan@faithful.be> writes: >> >>> On Sep 9, 2014, at 06:27 , pkx166h@gmail.com wrote: >>> >>>> I will manually update the tracker issue for this, but please make sure >>>> that if you do any updates to an issue that you also update the tracker >>>> so the automatic test tools catch the patch. It was only because I was >>>> randomly browsing my emails that I caught this. We don't want someone's >>>> hard work to be wasted. >>> >>> Thank you. eble@ticalc.org was working for some Google services, but >>> not Google Code. I created a new account >>> (nine.fierce.ballads@gmail.com) that I will use for future work. The >>> tracker shows that I’m logged in, so hopefully the automated >>> notification will work next time. >> >> Well, if you take a look at the copied Email addresses in your mail, >> you'll find that Keith and myself get along without a Gmail account. > > I was under the impression that you had a Google account, but not a > Google email address? That's what "without a Gmail account" is about. I have a Google Code account, no Google Mail account/address. -- David Kastrup
Sign in to reply to this message.
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
