Issue 14102043: Quote metacharacters in storage dir

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 14102043: Quote metacharacters in storage dir (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 7 months ago by axw

Modified:
10 years, 7 months ago

Reviewers:
mp+188230, axw1

Visibility:
Public.

Description

Quote metacharacters in storage dir Also, do away with export TMPDIR and use mktemp --tmpdir. https://code.launchpad.net/~axwalk/juju-core/sshstorage-fixes/+merge/188230 Requires: https://code.launchpad.net/~axwalk/juju-core/null-provider-customsources/+merge/187978 (do not edit description out of merge proposal)

Patch Set 1 #

Created: 10 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+69 lines, -28 lines)			Patch
A	[revision details]	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	cmd/juju/bootstrap.go	View	1 chunk	+1 line, -2 lines	0 comments	Download
M	environs/interface.go	View	1 chunk	+4 lines, -4 lines	0 comments	Download
M	environs/manual/bootstrap.go	View	2 chunks	+1 line, -1 line	0 comments	Download
M	environs/sshstorage/storage.go	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	environs/sshstorage/storage_test.go	View	1 chunk	+10 lines, -0 lines	0 comments	Download
M	provider/null/environ.go	View	4 chunks	+19 lines, -17 lines	0 comments	Download
M	provider/null/environ_test.go	View	3 chunks	+30 lines, -2 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

axw1

10 years, 7 months ago (2013-10-01 03:30:18 UTC) #2

On 2013/09/29 16:23:40, axw wrote:
> Please take a look.

Ignore this, going to do another CL which streams input to Put.

Expand All Messages | Collapse All Messages