Hello rsc@golang.org (cc: golang-codereviews@googlegroups.com), I'd like you to review this change to https://dvyukov%40google.com@code.google.com/p/go/
10 years, 6 months ago
(2014-09-04 06:16:06 UTC)
#1
LGTM. On Thu, Sep 4, 2014 at 4:16 PM, dvyukov via golang-codereviews <golang-codereviews@googlegroups.com> wrote: > ...
10 years, 6 months ago
(2014-09-04 06:19:55 UTC)
#3
LGTM.
On Thu, Sep 4, 2014 at 4:16 PM, dvyukov via golang-codereviews
<golang-codereviews@googlegroups.com> wrote:
> Reviewers: rsc,
>
> Message:
> Hello rsc@golang.org (cc: golang-codereviews@googlegroups.com),
>
> I'd like you to review this change to
> https://dvyukov%40google.com@code.google.com/p/go/
>
>
> Description:
> runtime: fix arm build
>
> Please review this at https://codereview.appspot.com/140990043/
>
> Affected files (+1, -1 lines):
> M src/pkg/runtime/atomic_arm.c
>
>
> Index: src/pkg/runtime/atomic_arm.c
> ===================================================================
> --- a/src/pkg/runtime/atomic_arm.c
> +++ b/src/pkg/runtime/atomic_arm.c
> @@ -58,7 +58,7 @@
> void*
> runtime·xchguintptr(void* volatile* addr, void* v)
> {
> - return runtime·xchg((uint32*)addr, (uint32)v);
> + return (void*)runtime·xchg((uint32*)addr, (uint32)v);
> }
>
> #pragma textflag NOSPLIT
>
>
> --
> You received this message because you are subscribed to the Google Groups
> "golang-codereviews" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to golang-codereviews+unsubscribe@googlegroups.com.
> For more options, visit https://groups.google.com/d/optout.
Issue 140990043: code review 140990043: runtime: fix arm build
(Closed)
Created 10 years, 6 months ago by dvyukov
Modified 10 years, 6 months ago
Reviewers: dave_cheney.net
Base URL:
Comments: 0