Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(527)

Issue 140990043: code review 140990043: runtime: fix arm build (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 6 months ago by dvyukov
Modified:
10 years, 6 months ago
Reviewers:
dave
CC:
rsc, golang-codereviews
Visibility:
Public.

Description

runtime: fix arm build

Patch Set 1 #

Patch Set 2 : diff -r ae8c0a71a2e6164f59bede6593c994d5752be057 https://dvyukov%40google.com@code.google.com/p/go/ #

Patch Set 3 : diff -r ae8c0a71a2e6164f59bede6593c994d5752be057 https://dvyukov%40google.com@code.google.com/p/go/ #

Patch Set 4 : diff -r ae8c0a71a2e6164f59bede6593c994d5752be057 https://dvyukov%40google.com@code.google.com/p/go/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M src/pkg/runtime/atomic_arm.c View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3
dvyukov
Hello rsc@golang.org (cc: golang-codereviews@googlegroups.com), I'd like you to review this change to https://dvyukov%40google.com@code.google.com/p/go/
10 years, 6 months ago (2014-09-04 06:16:06 UTC) #1
dvyukov
*** Submitted as https://code.google.com/p/go/source/detail?r=f299fefb123f *** runtime: fix arm build TBR=rsc R=rsc CC=golang-codereviews https://codereview.appspot.com/140990043
10 years, 6 months ago (2014-09-04 06:17:05 UTC) #2
dave_cheney.net
10 years, 6 months ago (2014-09-04 06:19:55 UTC) #3
LGTM.

On Thu, Sep 4, 2014 at 4:16 PM, dvyukov via golang-codereviews
<golang-codereviews@googlegroups.com> wrote:
> Reviewers: rsc,
>
> Message:
> Hello rsc@golang.org (cc: golang-codereviews@googlegroups.com),
>
> I'd like you to review this change to
> https://dvyukov%40google.com@code.google.com/p/go/
>
>
> Description:
> runtime: fix arm build
>
> Please review this at https://codereview.appspot.com/140990043/
>
> Affected files (+1, -1 lines):
>   M src/pkg/runtime/atomic_arm.c
>
>
> Index: src/pkg/runtime/atomic_arm.c
> ===================================================================
> --- a/src/pkg/runtime/atomic_arm.c
> +++ b/src/pkg/runtime/atomic_arm.c
> @@ -58,7 +58,7 @@
>  void*
>  runtime·xchguintptr(void* volatile* addr, void* v)
>  {
> -       return runtime·xchg((uint32*)addr, (uint32)v);
> +       return (void*)runtime·xchg((uint32*)addr, (uint32)v);
>  }
>
>  #pragma textflag NOSPLIT
>
>
> --
> You received this message because you are subscribed to the Google Groups
> "golang-codereviews" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to golang-codereviews+unsubscribe@googlegroups.com.
> For more options, visit https://groups.google.com/d/optout.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b