Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(33)

Issue 140870044: code review 140870044: runtime: introduce, use funcPC to convert Go func to PC (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
7 years, 1 month ago by rsc
Modified:
7 years, 1 month ago
Reviewers:
r, dfc, iant
CC:
golang-codereviews, dfc, r, iant, dvyukov, khr
Visibility:
Public.

Description

runtime: introduce, use funcPC to convert Go func to PC This removes the ** unsafe hack. Real bug fixed at chan.go:101.

Patch Set 1 #

Patch Set 2 : diff -r 9227fb9e97fdaddfab9a43aa3894178c14284e6b https://code.google.com/p/go/ #

Patch Set 3 : diff -r 9227fb9e97fdaddfab9a43aa3894178c14284e6b https://code.google.com/p/go/ #

Patch Set 4 : diff -r 9227fb9e97fdaddfab9a43aa3894178c14284e6b https://code.google.com/p/go/ #

Patch Set 5 : diff -r 2008238cdc04dc6419ab75310eb8e6ee17098481 https://code.google.com/p/go/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -72 lines) Patch
M src/pkg/runtime/chan.go View 1 2 3 chunks +3 lines, -9 lines 0 comments Download
M src/pkg/runtime/cpuprof.go View 1 1 chunk +1 line, -2 lines 0 comments Download
M src/pkg/runtime/export_test.go View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M src/pkg/runtime/hashmap.go View 1 7 chunks +7 lines, -17 lines 0 comments Download
M src/pkg/runtime/hashmap_fast.go View 1 6 chunks +6 lines, -18 lines 0 comments Download
M src/pkg/runtime/proc.go View 1 1 chunk +6 lines, -0 lines 0 comments Download
M src/pkg/runtime/select.go View 1 2 3 3 chunks +3 lines, -12 lines 0 comments Download
M src/pkg/runtime/slice.go View 1 2 3 3 chunks +3 lines, -7 lines 0 comments Download
M src/pkg/runtime/string.go View 1 3 chunks +3 lines, -6 lines 0 comments Download

Messages

Total messages: 5
rsc
Hello golang-codereviews@googlegroups.com (cc: dvyukov, iant, khr, r), I'd like you to review this change to ...
7 years, 1 month ago (2014-09-03 00:41:42 UTC) #1
dfc
LGTM. Nice catch on chan.go
7 years, 1 month ago (2014-09-03 00:48:03 UTC) #2
r
LGTM much nicer
7 years, 1 month ago (2014-09-03 01:03:47 UTC) #3
iant
LGTM
7 years, 1 month ago (2014-09-03 14:12:06 UTC) #4
rsc
7 years, 1 month ago (2014-09-03 15:10:46 UTC) #5
*** Submitted as https://code.google.com/p/go/source/detail?r=0b83bb7bb7ec ***

runtime: introduce, use funcPC to convert Go func to PC

This removes the ** unsafe hack.

Real bug fixed at chan.go:101.

LGTM=dave, r, iant
R=golang-codereviews, dave, r, iant
CC=dvyukov, golang-codereviews, khr
https://codereview.appspot.com/140870044
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b