Issue 140870044: code review 140870044: runtime: introduce, use funcPC to convert Go func to PC

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 140870044: code review 140870044: runtime: introduce, use funcPC to convert Go func to PC (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
9 years, 7 months ago by rsc

Modified:
9 years, 7 months ago

Reviewers:
r, dave, iant

CC:
golang-codereviews, dave_cheney.net, r, iant, dvyukov, khr

Visibility:
Public.

Description

runtime: introduce, use funcPC to convert Go func to PC This removes the ** unsafe hack. Real bug fixed at chan.go:101.

Patch Set 1 #

Patch Set 2 : diff -r 9227fb9e97fdaddfab9a43aa3894178c14284e6b https://code.google.com/p/go/ #

Patch Set 3 : diff -r 9227fb9e97fdaddfab9a43aa3894178c14284e6b https://code.google.com/p/go/ #

Patch Set 4 : diff -r 9227fb9e97fdaddfab9a43aa3894178c14284e6b https://code.google.com/p/go/ #

Patch Set 5 : diff -r 2008238cdc04dc6419ab75310eb8e6ee17098481 https://code.google.com/p/go/ #

Created: 9 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+33 lines, -72 lines)			Patch
M	src/pkg/runtime/chan.go	View	1 2	3 chunks	+3 lines, -9 lines	0 comments	Download
M	src/pkg/runtime/cpuprof.go	View	1	1 chunk	+1 line, -2 lines	0 comments	Download
M	src/pkg/runtime/export_test.go	View	1 2 3 4	1 chunk	+1 line, -1 line	0 comments	Download
M	src/pkg/runtime/hashmap.go	View	1	7 chunks	+7 lines, -17 lines	0 comments	Download
M	src/pkg/runtime/hashmap_fast.go	View	1	6 chunks	+6 lines, -18 lines	0 comments	Download
M	src/pkg/runtime/proc.go	View	1	1 chunk	+6 lines, -0 lines	0 comments	Download
M	src/pkg/runtime/select.go	View	1 2 3	3 chunks	+3 lines, -12 lines	0 comments	Download
M	src/pkg/runtime/slice.go	View	1 2 3	3 chunks	+3 lines, -7 lines	0 comments	Download
M	src/pkg/runtime/string.go	View	1	3 chunks	+3 lines, -6 lines	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

rsc

Hello golang-codereviews@googlegroups.com (cc: dvyukov, iant, khr, r), I'd like you to review this change to ...

9 years, 7 months ago (2014-09-03 00:41:42 UTC) #1

rsc

9 years, 7 months ago (2014-09-03 15:10:46 UTC) #5

*** Submitted as https://code.google.com/p/go/source/detail?r=0b83bb7bb7ec ***

runtime: introduce, use funcPC to convert Go func to PC

This removes the ** unsafe hack.

Real bug fixed at chan.go:101.

LGTM=dave, r, iant
R=golang-codereviews, dave, r, iant
CC=dvyukov, golang-codereviews, khr
https://codereview.appspot.com/140870044

Expand All Messages | Collapse All Messages