Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(39)

Issue 140830043: code review 140830043: cmd/gc: fix runtime print(hex(x)) (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 6 months ago by rsc
Modified:
10 years, 6 months ago
Reviewers:
gobot, iant
CC:
golang-codereviews, iant, r
Visibility:
Public.

Description

cmd/gc: fix runtime print(hex(x)) The code I wrote originally works for trivial functions that are inlined at a call site in another package, because that was how I wrote my local test. Make hex(x) work for non-inlinable functions too.

Patch Set 1 #

Patch Set 2 : diff -r 7844c28fa2952f205ee365c89a213bb0c1627528 https://code.google.com/p/go/ #

Patch Set 3 : diff -r 6aabcc1ffb70dbe0cca91f8f46176a26012ba2e9 https://code.google.com/p/go/ #

Patch Set 4 : diff -r 6aabcc1ffb70dbe0cca91f8f46176a26012ba2e9 https://code.google.com/p/go/ #

Patch Set 5 : diff -r 473a2c28eb342eae133c6b91b9511afeeba04c9e https://code.google.com/p/go/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M src/cmd/gc/walk.c View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4
rsc
Hello golang-codereviews@googlegroups.com (cc: iant, r), I'd like you to review this change to https://code.google.com/p/go/
10 years, 6 months ago (2014-09-02 02:28:08 UTC) #1
iant
LGTM
10 years, 6 months ago (2014-09-02 13:36:48 UTC) #2
rsc
*** Submitted as https://code.google.com/p/go/source/detail?r=df0572446e37 *** cmd/gc: fix runtime print(hex(x)) The code I wrote originally works ...
10 years, 6 months ago (2014-09-02 18:36:30 UTC) #3
gobot
10 years, 6 months ago (2014-09-03 00:33:11 UTC) #4
Message was sent while issue was closed.
This CL appears to have broken the nacl-386-temp builder.
See http://build.golang.org/log/ac7e5d7f8133df86d6d62f1c6685b79309411ec1
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b