Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(567)

Issue 140440044: code review 140440044: runtime: fix windows/386 build (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 6 months ago by rsc
Modified:
10 years, 6 months ago
Reviewers:
gobot, iant
CC:
golang-codereviews
Visibility:
Public.

Description

runtime: fix windows/386 build The difference between the old and the new (from earlier) code is that we set stackguard = stack.lo + StackGuard, while the old code set stackguard = stack.lo. That 512 bytes appears to be the difference between the profileloop function running and not running. We don't know how big the system stack is, but it is likely MUCH bigger than 4k. Give Go/C 8k.

Patch Set 1 #

Patch Set 2 : diff -r 1ad196212ec464e41a35c4bd5553bf302e8e887b https://code.google.com/p/go/ #

Patch Set 3 : diff -r 1ad196212ec464e41a35c4bd5553bf302e8e887b https://code.google.com/p/go/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -1 line) Patch
M src/runtime/memclr_386.s View 1 1 chunk +2 lines, -0 lines 0 comments Download
M src/runtime/memclr_amd64.s View 1 1 chunk +2 lines, -0 lines 0 comments Download
M src/runtime/sys_windows_386.s View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4
rsc
Hello iant (cc: golang-codereviews@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go/
10 years, 6 months ago (2014-09-09 21:12:03 UTC) #1
rsc
*** Submitted as https://code.google.com/p/go/source/detail?r=a734060a64b9 *** runtime: fix windows/386 build The difference between the old and ...
10 years, 6 months ago (2014-09-09 21:12:08 UTC) #2
gobot
This CL appears to have broken the linux-386 builder. See http://build.golang.org/log/c6bc2866c5ef017c6f43a9c4f860cf3f9c7e301e
10 years, 6 months ago (2014-09-09 21:16:39 UTC) #3
iant
10 years, 6 months ago (2014-09-09 21:29:08 UTC) #4
Message was sent while issue was closed.
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b