Issue 14041043: Update samples solution to use the new translator project and add missing files to the translator p…

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 14041043: Update samples solution to use the new translator project and add missing files to the translator p… (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 7 months ago by Geoff Lang

Modified:
10 years, 7 months ago

Reviewers:
zmo, Zhenyao Mo, Shannon Woods, Jamie Madill

CC:
angleproject-review_googlegroups.com

Base URL:
https://code.google.com/p/angleproject/@master

Visibility:
Public.

Update samples solution to use the new translator project and add missing files to the translator project. BUG=

Created: 10 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+49 lines, -19 lines)			Patch
M	samples/samples.sln	View	2 chunks	+1 line, -11 lines	0 comments	Download
M	samples/translator/essl_to_hlsl.vcxproj	View	1 chunk	+0 lines, -8 lines	0 comments	Download
M	src/compiler/translator_common.vcxproj	View	6 chunks	+12 lines, -0 lines	0 comments	Download
M	src/compiler/translator_common.vcxproj.filters	View	2 chunks	+36 lines, -0 lines	0 comments	Download

Total messages: 4

Jamie Madill

Could you rename the translator_common project to translator to be consistent with the previous patches? ...

10 years, 7 months ago (2013-09-27 13:53:46 UTC) #1

Zhenyao Mo

On 2013/09/27 13:54:36, Geoff Lang wrote: > PTAL LGTM (I tried to rename the filenames, ...

10 years, 7 months ago (2013-09-27 16:45:35 UTC) #3

LGTM, was committed with my changes