Move resultsToCharmlist to transformResults.

Move resultsToCharmlist to transformResults.

In APIv3 support bundles and return an array of charm and bundle objects.

https://code.launchpad.net/~bac/juju-gui/bundle-open-api/+merge/187941

(do not edit description out of merge proposal)

[bac, 2013-09-27 12:42:06]

Please take a look.

[benji, 2013-09-27 13:11:21]

Very nice.

LGTM-ly y'rs
Benji

https://codereview.appspot.com/14036044/diff/1/app/store/charm.js
File app/store/charm.js (right):

https://codereview.appspot.com/14036044/diff/1/app/store/charm.js#newcode131
app/store/charm.js:131: * Send the actual request and handle response from the
API.
Pendantry high-five!

https://codereview.appspot.com/14036044/diff/1/app/store/charm.js#newcode420
app/store/charm.js:420: *
An @return would be nice.

https://codereview.appspot.com/14036044/diff/1/app/store/charm.js#newcode430
app/store/charm.js:430: if (entity.charm !== undefined) {
It would be a teeny-tiny bit clearer if this were a non-negative test... almost
not worth mentioning.

https://codereview.appspot.com/14036044/diff/1/app/store/charm.js#newcode724
app/store/charm.js:724: * @param {Object} JSON decoded data from response.
[This was just moved from above, I know, but...] an @return would be nice.

https://codereview.appspot.com/14036044/diff/1/test/utils.js
File test/utils.js (left):

https://codereview.appspot.com/14036044/diff/1/test/utils.js#oldcode140
test/utils.js:140: makeFakeStore: function(cache) {
I guess no code ever passed in a cache, right?

https://codereview.appspot.com/14036044/diff/1/test/utils.js
File test/utils.js (right):

https://codereview.appspot.com/14036044/diff/1/test/utils.js#newcode142
test/utils.js:142: if (version === 3) {
Nice use of JavaScript's missing argument semantics.

[bac, 2013-09-27 14:50:51]

*** Submitted:

Move resultsToCharmlist to transformResults.

In APIv3 support bundles and return an array of charm and bundle objects.

R=benji
CC=
https://codereview.appspot.com/14036044

https://codereview.appspot.com/14036044/diff/1/app/store/charm.js
File app/store/charm.js (right):

https://codereview.appspot.com/14036044/diff/1/app/store/charm.js#newcode131
app/store/charm.js:131: * Send the actual request and handle response from the
API.
On 2013/09/27 13:11:21, benji wrote:
> Pendantry high-five!

Done.

https://codereview.appspot.com/14036044/diff/1/app/store/charm.js#newcode420
app/store/charm.js:420: *
On 2013/09/27 13:11:21, benji wrote:
> An @return would be nice.

Done.

https://codereview.appspot.com/14036044/diff/1/app/store/charm.js#newcode430
app/store/charm.js:430: if (entity.charm !== undefined) {
On 2013/09/27 13:11:21, benji wrote:
> It would be a teeny-tiny bit clearer if this were a non-negative test...
almost
> not worth mentioning.

Done.

https://codereview.appspot.com/14036044/diff/1/app/store/charm.js#newcode724
app/store/charm.js:724: * @param {Object} JSON decoded data from response.
On 2013/09/27 13:11:21, benji wrote:
> [This was just moved from above, I know, but...] an @return would be nice.

Done.

https://codereview.appspot.com/14036044/diff/1/test/test_model.js
File test/test_model.js (left):

https://codereview.appspot.com/14036044/diff/1/test/test_model.js#oldcode808
test/test_model.js:808: fakeStore = utils.makeFakeStore(db.charms);
This is the test that was passing a cache that was never used.

https://codereview.appspot.com/14036044/diff/1/test/utils.js
File test/utils.js (left):

https://codereview.appspot.com/14036044/diff/1/test/utils.js#oldcode140
test/utils.js:140: makeFakeStore: function(cache) {
Well one did (see below) but it wasn't used, which was missed due to the
confusing re-use of the 'cache' parameter below in the returned method.