code review 140360043: go.tools/cmd/stringer: add .exe suffix to executable na...

go.tools/cmd/stringer: add .exe suffix to executable name in TestEndToEnd

Fixes windows build

[brainman, 2014-09-08 02:47:07]

Hello golang-codereviews@googlegroups.com,

I'd like you to review this change to
https://code.google.com/p/go.tools

[bradfitz, 2014-09-08 03:46:10]

LGTM


On Sun, Sep 7, 2014 at 7:47 PM, <alex.brainman@gmail.com> wrote:

> Reviewers: golang-codereviews,
>
> Message:
> Hello golang-codereviews@googlegroups.com,
>
> I'd like you to review this change to
> https://code.google.com/p/go.tools
>
>
> Description:
> go.tools/cmd/stringer: add .exe suffix to executable name in
> TestEndToEnd
>
> Fixes windows build
>
> Please review this at https://codereview.appspot.com/140360043/
>
> Affected files (+1, -1 lines):
>   M cmd/stringer/endtoend_test.go
>
>
> Index: cmd/stringer/endtoend_test.go
> ===================================================================
> --- a/cmd/stringer/endtoend_test.go
> +++ b/cmd/stringer/endtoend_test.go
> @@ -24,7 +24,7 @@
>         dir, err := ioutil.TempDir("", "stringer")
>         defer os.RemoveAll(dir)
>         // Create stringer in temporary directory.
> -       stringer := filepath.Join(dir, "stringer")
> +       stringer := filepath.Join(dir, "stringer.exe")
>         err = run("go", "build", "-o", stringer, "stringer.go")
>         if err != nil {
>                 t.Fatalf("building stringer: %s", err)
>
>
> --
> You received this message because you are subscribed to the Google Groups
> "golang-codereviews" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to golang-codereviews+unsubscribe@googlegroups.com.
> For more options, visit https://groups.google.com/d/optout.
>

[brainman, 2014-09-08 03:55:10]

*** Submitted as
https://code.google.com/p/go/source/detail?r=552592090d70&repo=tools ***

go.tools/cmd/stringer: add .exe suffix to executable name in TestEndToEnd

Fixes windows build

LGTM=bradfitz
R=golang-codereviews, bradfitz
CC=golang-codereviews
https://codereview.appspot.com/140360043

[brainman, 2014-09-08 03:55:58]

On 2014/09/08 03:46:10, bradfitz wrote:
> LGTM
> 

Builders are so quick now. Thank you.

Alex

[bradfitz, 2014-09-08 04:01:19]

On Sun, Sep 7, 2014 at 8:55 PM, <alex.brainman@gmail.com> wrote:

> On 2014/09/08 03:46:10, bradfitz wrote:
>
>> LGTM
>>
>
>
> Builders are so quick now. Thank you.
>

You haven't seen anything, yet. I think they can still be much faster. :-)