Issue 14031045: Assure bundles can be displayed in search results.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 14031045: Assure bundles can be displayed in search results.

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 6 months ago by benji

Modified:
10 years, 6 months ago

Reviewers:
mp+188142, bac

Visibility:
Public.

Description

Assure bundles can be displayed in search results. https://code.launchpad.net/~benji/juju-gui/bundles-in-search/+merge/188142 (do not edit description out of merge proposal)

Patch Set 2 : Assure bundles can be displayed in search results. #

Created: 10 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+50 lines, -6 lines)			Patch
	A	[revision details]	View		1 chunk	+2 lines, -0 lines	0 comments	Download
	M	test/test_browser_search_view.js	View		4 chunks	+48 lines, -6 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

bac

LGTM. Nice test. https://codereview.appspot.com/14031045/diff/1/test/test_browser_search_view.js File test/test_browser_search_view.js (right): https://codereview.appspot.com/14031045/diff/1/test/test_browser_search_view.js#newcode253 test/test_browser_search_view.js:253: // Stubbing the server callback value ...

10 years, 6 months ago (2013-09-27 19:07:34 UTC) #2

benji

10 years, 6 months ago (2013-09-27 19:14:38 UTC) #3

*** Submitted:

Assure bundles can be displayed in search results.

R=bac
CC=
https://codereview.appspot.com/14031045

Expand All Messages | Collapse All Messages