Issue 140220043: code review 140220043: runtime: fix netbsd build

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 140220043: code review 140220043: runtime: fix netbsd build (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years ago by dvyukov

Modified:
11 years ago

Reviewers:
minux

CC:
rsc, golang-codereviews

Visibility:
Public.

Description

runtime: fix netbsd build

Patch Set 1 #

Patch Set 2 : diff -r f299fefb123fb13f49025e418ba104146e622ae1 https://dvyukov%40google.com@code.google.com/p/go/ #

Patch Set 3 : diff -r f299fefb123fb13f49025e418ba104146e622ae1 https://dvyukov%40google.com@code.google.com/p/go/ #

Patch Set 4 : diff -r 9efb90d89fdb518751e7e864fd78e999c102aa7e https://dvyukov%40google.com@code.google.com/p/go/ #

Created: 11 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -3 lines)			Patch
M	src/pkg/runtime/defs_netbsd_386.h	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	src/pkg/runtime/defs_netbsd_amd64.h	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	src/pkg/runtime/defs_netbsd_arm.h	View	1	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

dvyukov

Hello rsc@golang.org (cc: golang-codereviews@googlegroups.com), I'd like you to review this change to https://dvyukov%40google.com@code.google.com/p/go/

11 years ago (2014-09-04 06:22:54 UTC) #1

dvyukov

*** Submitted as https://code.google.com/p/go/source/detail?r=e7026172ac52 *** runtime: fix netbsd build TBR=rsc R=rsc CC=golang-codereviews https://codereview.appspot.com/140220043

11 years ago (2014-09-04 07:31:46 UTC) #2

LGTM.

Expand All Messages | Collapse All Messages