Issue 140200043: code review 140200043: dashboard: add Cloud Storage upload support to create.go

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 140200043: code review 140200043: dashboard: add Cloud Storage upload support to create.go (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years ago by bradfitz

Modified:
11 years ago

Reviewers:
adg

CC:
adg, golang-codereviews

Visibility:
Public.

Description

dashboard: add Cloud Storage upload support to create.go Then make the coordinator and linux environment Makefiles have an upload target. Amusingly, this actually worked: the Docker images now tar + compress + upload over HTTP all in a stream, without even knowing how large the resulting tar.gz will be until it's done uploading.

Patch Set 1 #

Patch Set 2 : diff -r 31a082a3b5de90a66659edcfb9c97fc9db2cab84 https://code.google.com/p/go.tools #

Patch Set 3 : diff -r 31a082a3b5de90a66659edcfb9c97fc9db2cab84 https://code.google.com/p/go.tools #

Total comments: 1

Patch Set 4 : diff -r 55407ca4191da3f9bcf88a787baaff24a9eb9d97 https://code.google.com/p/go.tools #

Created: 11 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+52 lines, -18 lines)			Patch
M	.hgignore	View	1	1 chunk	+0 lines, -3 lines	0 comments	Download
A	dashboard/coordinator/Makefile	View	1	1 chunk	+6 lines, -0 lines	0 comments	Download
M	dashboard/coordinator/buildongce/create.go	View	1	6 chunks	+41 lines, -3 lines	0 comments	Download
M	dashboard/env/linux-x86-base/Makefile	View	1 2 3	1 chunk	+2 lines, -5 lines	0 comments	Download
M	dashboard/env/linux-x86-nacl/Makefile	View	1 2 3	1 chunk	+3 lines, -7 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

bradfitz

Hello adg@golang.org (cc: golang-codereviews@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go.tools

11 years ago (2014-09-04 01:29:19 UTC) #1

adg

LGTM https://codereview.appspot.com/140200043/diff/40001/dashboard/coordinator/Makefile File dashboard/coordinator/Makefile (right): https://codereview.appspot.com/140200043/diff/40001/dashboard/coordinator/Makefile#newcode2 dashboard/coordinator/Makefile:2: GOOS=linux go build -o coordinator . s/ .//

11 years ago (2014-09-04 01:44:36 UTC) #2

bradfitz

11 years ago (2014-09-04 04:41:18 UTC) #3

*** Submitted as
https://code.google.com/p/go/source/detail?r=2b74c7515acf&repo=tools ***

dashboard: add Cloud Storage upload support to create.go

Then make the coordinator and linux environment Makefiles have
an upload target. Amusingly, this actually worked: the Docker
images now tar + compress + upload over HTTP all in a stream,
without even knowing how large the resulting tar.gz will be until
it's done uploading.

LGTM=adg
R=adg
CC=golang-codereviews
https://codereview.appspot.com/140200043

Expand All Messages | Collapse All Messages