code review 140180043: runtime: remove guard against uninitialized forcegc.g

runtime: remove guard against uninitialized forcegc.g

The race was in the old C code.
The new Go code does not have the race
and does not need the check.

[rsc, 2014-09-03 15:39:08]

Hello golang-codereviews@googlegroups.com (cc: dvyukov, rlh),

I'd like you to review this change to
https://code.google.com/p/go/

[bradfitz, 2014-09-03 15:49:18]

LGTM

(was following other thread)



On Wed, Sep 3, 2014 at 8:39 AM, <rsc@golang.org> wrote:

> Reviewers: golang-codereviews,
>
> Message:
> Hello golang-codereviews@googlegroups.com (cc: dvyukov, rlh),
>
> I'd like you to review this change to
> https://code.google.com/p/go/
>
>
> Description:
> runtime: remove guard against uninitialized forcegc.g
>
> The race was in the old C code.
> The new Go code does not have the race
> and does not need the check.
>
> Please review this at https://codereview.appspot.com/140180043/
>
> Affected files (+3, -6 lines):
>   M src/pkg/runtime/proc.c
>
>
> Index: src/pkg/runtime/proc.c
> ===================================================================
> --- a/src/pkg/runtime/proc.c
> +++ b/src/pkg/runtime/proc.c
> @@ -2759,12 +2759,9 @@
>                 lastgc = runtime·atomicload64(&mstats.last_gc);
>                 if(lastgc != 0 && unixnow - lastgc > forcegcperiod &&
> runtime·atomicload(&runtime·forcegc.idle)) {
>                         runtime·lock(&runtime·forcegc.lock);
> -                       if(runtime·forcegc.g != nil) {
> -                               // Goroutine may be started but has not
> initialized g yet.
> -                               runtime·forcegc.idle = 0;
> -                               runtime·forcegc.g->schedlink = nil;
> -                               injectglist(runtime·forcegc.g);
> -                       }
> +                       runtime·forcegc.idle = 0;
> +                       runtime·forcegc.g->schedlink = nil;
> +                       injectglist(runtime·forcegc.g);
>                         runtime·unlock(&runtime·forcegc.lock);
>                 }
>
>
>
> --
> You received this message because you are subscribed to the Google Groups
> "golang-codereviews" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to golang-codereviews+unsubscribe@googlegroups.com.
> For more options, visit https://groups.google.com/d/optout.
>

[dvyukov, 2014-09-03 16:25:24]

LGTM

[rsc, 2014-09-03 16:48:37]

*** Submitted as https://code.google.com/p/go/source/detail?r=d4f709af0cc6 ***

runtime: remove guard against uninitialized forcegc.g

The race was in the old C code.
The new Go code does not have the race
and does not need the check.

LGTM=bradfitz, dvyukov
R=golang-codereviews, bradfitz, dvyukov
CC=golang-codereviews, rlh
https://codereview.appspot.com/140180043

[gobot, 2014-09-03 16:55:13]

This CL appears to have broken the linux-386-temp builder.
See http://build.golang.org/log/1a26b13dd3a3bbf42a74bad13b40c49d6255ceea

[rlh, 2014-09-03 17:08:10]

On 2014/09/03 16:55:13, gobot wrote:
> This CL appears to have broken the linux-386-temp builder.
> See http://build.golang.org/log/1a26b13dd3a3bbf42a74bad13b40c49d6255ceea

LGTM