Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(31)

Issue 140180043: code review 140180043: runtime: remove guard against uninitialized forcegc.g (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 6 months ago by rsc
Modified:
10 years, 6 months ago
Reviewers:
gobot, rlh, dvyukov, bradfitz
CC:
golang-codereviews, bradfitz, dvyukov
Visibility:
Public.

Description

runtime: remove guard against uninitialized forcegc.g The race was in the old C code. The new Go code does not have the race and does not need the check.

Patch Set 1 #

Patch Set 2 : diff -r 1bc626afe666112f7a74cebe058191acebd06023 https://code.google.com/p/go/ #

Patch Set 3 : diff -r 1bc626afe666112f7a74cebe058191acebd06023 https://code.google.com/p/go/ #

Patch Set 4 : diff -r a48637f85ed15ed19db9d8542c4903d8715555c1 https://code.google.com/p/go/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -6 lines) Patch
M src/pkg/runtime/proc.c View 1 2 3 1 chunk +3 lines, -6 lines 0 comments Download

Messages

Total messages: 6
rsc
Hello golang-codereviews@googlegroups.com (cc: dvyukov, rlh), I'd like you to review this change to https://code.google.com/p/go/
10 years, 6 months ago (2014-09-03 15:39:08 UTC) #1
bradfitz
LGTM (was following other thread) On Wed, Sep 3, 2014 at 8:39 AM, <rsc@golang.org> wrote: ...
10 years, 6 months ago (2014-09-03 15:49:18 UTC) #2
dvyukov
LGTM
10 years, 6 months ago (2014-09-03 16:25:24 UTC) #3
rsc
*** Submitted as https://code.google.com/p/go/source/detail?r=d4f709af0cc6 *** runtime: remove guard against uninitialized forcegc.g The race was in ...
10 years, 6 months ago (2014-09-03 16:48:37 UTC) #4
gobot
This CL appears to have broken the linux-386-temp builder. See http://build.golang.org/log/1a26b13dd3a3bbf42a74bad13b40c49d6255ceea
10 years, 6 months ago (2014-09-03 16:55:13 UTC) #5
rlh
10 years, 6 months ago (2014-09-03 17:08:10 UTC) #6
Message was sent while issue was closed.
On 2014/09/03 16:55:13, gobot wrote:
> This CL appears to have broken the linux-386-temp builder.
> See http://build.golang.org/log/1a26b13dd3a3bbf42a74bad13b40c49d6255ceea

LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b