Issue 14017043: code review 14017043: misc/vim: godoc is optional. so should point installati...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 14017043: code review 14017043: misc/vim: godoc is optional. so should point installati...

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 7 months ago by mattn

Modified:
10 years, 7 months ago

Reviewers:
r, dsymonds

CC:
golang-dev, r, dsymonds

Visibility:
Public.

Description

misc/vim: godoc is optional. so should point installation instruction.

Patch Set 2 : diff -r 28fb312f69c4 http://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 28fb312f69c4 http://go.googlecode.com/hg/ #

Total comments: 2

Patch Set 4 : diff -r 28fb312f69c4 http://go.googlecode.com/hg/ #

Created: 10 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -0 lines)			Patch
	M	misc/vim/plugin/godoc.vim	View	1 2 3	1 chunk	+7 lines, -0 lines	0 comments	Download

Messages

Total messages: 6

Expand All Messages | Collapse All Messages

mattn

Hello golang-dev@googlegroups.com, I'd like you to review this change to http://go.googlecode.com/hg/

10 years, 7 months ago (2013-09-27 01:58:55 UTC) #1

https://codereview.appspot.com/14017043/diff/4002/misc/vim/plugin/godoc.vim File misc/vim/plugin/godoc.vim (right): https://codereview.appspot.com/14017043/diff/4002/misc/vim/plugin/godoc.vim#newcode72 misc/vim/plugin/godoc.vim:72: echo " install with: go install code.google.com/p/go.tools/cmd/godoc" should this ...

10 years, 7 months ago (2013-09-27 02:02:42 UTC) #2

mattn

10 years, 7 months ago (2013-09-27 02:04:01 UTC) #3

dsymonds

10 years, 7 months ago (2013-09-27 02:35:13 UTC) #6

*** Submitted as https://code.google.com/p/go/source/detail?r=c2bd3fc04622 ***

misc/vim: godoc is optional. so should point installation instruction.

R=golang-dev, r, dsymonds
CC=golang-dev
https://codereview.appspot.com/14017043

Committer: David Symonds <dsymonds@golang.org>

Expand All Messages | Collapse All Messages