Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(88)

Issue 140170044: Issue 4030: Lyrics associated to a Staff are placed on top of each other (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
9 years, 7 months ago by dak
Modified:
9 years, 6 months ago
Reviewers:
janek
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

Issue 4030: Lyrics associated to a Staff are placed on top of each other The approach here is simply to avoid attaching to noteheads that have actually started _before_ the current moment of time. It is somewhat irritating that includeGraceNotes cannot possibly be supported in associated voices with its own timing (rather than the fully synchronized \addlyrics or \lyricsto): Instead you need to use the same durations, including \grace constructs, in order to match the note you are aiming for.

Patch Set 1 #

Patch Set 2 : Fix typo from removing property #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -10 lines) Patch
M lily/extender-engraver.cc View 1 2 chunks +2 lines, -3 lines 0 comments Download
M lily/include/context.hh View 1 chunk +1 line, -1 line 0 comments Download
M lily/lyric-engraver.cc View 4 chunks +18 lines, -6 lines 0 comments Download

Messages

Total messages: 2
dak
Fix typo from removing property
9 years, 7 months ago (2014-09-04 13:37:50 UTC) #1
janek
9 years, 7 months ago (2014-09-07 09:59:07 UTC) #2
LGTM.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b