Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(10515)

Issue 14011045: Added bundle token HTML shell (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 6 months ago by huwshimi
Modified:
10 years, 6 months ago
Reviewers:
gary.poster, mp+187977
Visibility:
Public.

Description

Added bundle token HTML shell This branch adds content to the bundle token, some of which is just dummy placement content. There is also a drive-by fix for the charm details panel header content not being spaced correctly. https://code.launchpad.net/~huwshimi/juju-gui/bundle-token/+merge/187977 (do not edit description out of merge proposal)

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+526 lines, -3 lines) Patch
A [revision details] View 1 chunk +2 lines, -0 lines 0 comments Download
A app/assets/images/non-sprites/bundle-token.svg View 1 chunk +477 lines, -0 lines 0 comments Download
M app/subapps/browser/templates/browser_charm.handlebars View 1 chunk +1 line, -1 line 0 comments Download
M app/templates/bundle-token.handlebars View 1 chunk +35 lines, -1 line 0 comments Download
M lib/views/browser/token.less View 1 chunk +10 lines, -0 lines 0 comments Download
M test/test_token.js View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4
huwshimi
Please take a look.
10 years, 6 months ago (2013-09-27 05:20:30 UTC) #1
huwshimi
On 2013/09/27 05:20:30, huwshimi wrote: > Please take a look. I forgot to mention that ...
10 years, 6 months ago (2013-09-27 06:06:01 UTC) #2
gary.poster
LGTM. Thank you!
10 years, 6 months ago (2013-09-27 17:09:31 UTC) #3
gary.poster
10 years, 6 months ago (2013-09-27 17:47:22 UTC) #4
*** Submitted:

Added bundle token HTML shell

This branch adds content to the bundle token, some of which is just dummy
placement content.

There is also a drive-by fix for the charm details panel header content not
being spaced correctly.

R=gary.poster
CC=
https://codereview.appspot.com/14011045
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b