Issue 14007043: code review 14007043: goprotobuf: Rename ErrRequiredNotSet to RequiredNotSetError.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 14007043: code review 14007043: goprotobuf: Rename ErrRequiredNotSet to RequiredNotSetError. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 1 month ago by dsymonds

Modified:
12 years, 1 month ago

Reviewers:
r

CC:
r, golang-dev

Visibility:
Public.

Description

goprotobuf: Rename ErrRequiredNotSet to RequiredNotSetError. This then matches the standard Go style for error types.

Patch Set 1 #

Patch Set 2 : diff -r b69f6472e579 https://code.google.com/p/goprotobuf #

Patch Set 3 : diff -r b69f6472e579 https://code.google.com/p/goprotobuf #

Patch Set 4 : diff -r b69f6472e579 https://code.google.com/p/goprotobuf #

Created: 12 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+16 lines, -16 lines)			Patch
M	proto/all_test.go	View	1	4 chunks	+7 lines, -7 lines	0 comments	Download
M	proto/decode.go	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	proto/encode.go	View	1	4 chunks	+8 lines, -8 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

dsymonds

Hello r (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/goprotobuf

12 years, 1 month ago (2013-09-26 23:50:58 UTC) #1

dsymonds

12 years, 1 month ago (2013-09-27 00:02:43 UTC) #3

*** Submitted as
https://code.google.com/p/goprotobuf/source/detail?r=4aaee30bd610 ***

goprotobuf: Rename ErrRequiredNotSet to RequiredNotSetError.

This then matches the standard Go style for error types.

R=r
CC=golang-dev
https://codereview.appspot.com/14007043

Expand All Messages | Collapse All Messages