patch for issue 1030 - redirect stout and stderr on windows

[ced1, 2009-11-05 12:57:22]

http://codereview.appspot.com/140069/diff/1/2
File bin/tryton (right):

http://codereview.appspot.com/140069/diff/1/2#newcode11
Line 11: if os.name == 'nt':
It should be done only when embedded in py2exe

[timitos, 2009-11-05 19:39:36]

http://codereview.appspot.com/140069/diff/1/2
File bin/tryton (right):

http://codereview.appspot.com/140069/diff/1/2#newcode11
Line 11: if os.name == 'nt':
On 2009/11/05 12:57:22, ced wrote:
> It should be done only when embedded in py2exe

new patchset uploaded. should fix that.

[ced1, 2009-11-05 19:43:46]

http://codereview.appspot.com/140069/diff/2002/3002
File bin/tryton (right):

http://codereview.appspot.com/140069/diff/2002/3002#newcode12
Line 12: if os.name == 'nt' and hasattr(sys,"frozen"):
missing space after comma

http://codereview.appspot.com/140069/diff/2002/3002#newcode13
Line 13: if not os.path.isdir(os.path.join(os.environ['APPDATA'],"Tryton")):
Is APPDATA always set on windows?
Why not use the same directory then the config file?

[timitos, 2009-11-05 20:08:17]

http://codereview.appspot.com/140069/diff/2002/3002
File bin/tryton (right):

http://codereview.appspot.com/140069/diff/2002/3002#newcode12
Line 12: if os.name == 'nt' and hasattr(sys,"frozen"):
On 2009/11/05 19:43:46, ced wrote:
> missing space after comma

solved in patchset 3

http://codereview.appspot.com/140069/diff/2002/3002#newcode13
Line 13: if not os.path.isdir(os.path.join(os.environ['APPDATA'],"Tryton")):
On 2009/11/05 19:43:46, ced wrote:
> Is APPDATA always set on windows?
> Why not use the same directory then the config file?

because the directory of the config file is not the correct place. such files
should be saved under appdata. it is the common place. i think it could be good
to move the config file to APPDATA too.

for the moment i cannot say if APPDATA is always set. but it is used by common
applications as office and adobe reader.

look here:
http://bytes.com/topic/net/answers/638856-right-place-save-log-files#post2533825

[timitos, 2009-11-05 20:14:59]

http://codereview.appspot.com/140069/diff/2002/3002
File bin/tryton (right):

http://codereview.appspot.com/140069/diff/2002/3002#newcode13
Line 13: if not os.path.isdir(os.path.join(os.environ['APPDATA'],"Tryton")):
On 2009/11/05 19:43:46, ced wrote:
> Is APPDATA always set on windows?
> Why not use the same directory then the config file?

I found a better reference for APPDATA Topic:
http://www.python.org/dev/peps/pep-0370/#windows-notes

[ced1, 2009-11-05 21:47:05]

I'm wondering if it will not be better to simply close stdout and stderr.

[timitos, 2009-11-07 14:59:42]

On 2009/11/05 21:47:05, ced wrote:
> I'm wondering if it will not be better to simply close stdout and stderr.

Could be an option as exceptions will be catched by the issue tracker dialog
anyway. So there should be not very much loss. I can update the patch for this
solution.

[ced1, 2009-11-07 15:39:38]

On 2009/11/07 14:59:42, timitos wrote:
> On 2009/11/05 21:47:05, ced wrote:
> > I'm wondering if it will not be better to simply close stdout and stderr.
> 
> Could be an option as exceptions will be catched by the issue tracker dialog
> anyway. So there should be not very much loss. I can update the patch for this
> solution.

OK

[timitos, 2009-11-08 10:13:33]

new patchset uploaded.
i have the code from boot_common.py of py2exe.
please notice that py2exe has an MIT License.

[ced1, 2009-11-08 10:30:16]

http://codereview.appspot.com/140069/diff/5001/5002
File bin/tryton (right):

http://codereview.appspot.com/140069/diff/5001/5002#newcode21
bin/tryton:21: sys.stdout = NoWhere()
Why not:

sys.stdout = open(os.devnull, 'w')

[timitos, 2009-11-08 11:55:23]

seems to work. new patchset with os.devnull

[ced1, 2009-11-10 21:48:35]

Ok you can create a changeset for the issue.

[ced1, 2009-11-10 23:08:12]

Applied
Can be closed