Issue 140060043: code review 140060043: runtime: rename SysAlloc to sysAlloc for Go

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 140060043: code review 140060043: runtime: rename SysAlloc to sysAlloc for Go (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 6 months ago by rsc

Modified:
10 years, 6 months ago

Reviewers:
gobot, mdempsky

CC:
golang-codereviews, mdempsky, iant

Visibility:
Public.

Description

runtime: rename SysAlloc to sysAlloc for Go Renaming the C SysAlloc will let Go define a prototype without exporting it. For use in cpuprof.goc's translation to Go.

Patch Set 1 #

Patch Set 2 : diff -r 1041a5493f10e3c6edadc67e683f6aa6d832fd60 https://code.google.com/p/go/ #

Patch Set 3 : diff -r 1041a5493f10e3c6edadc67e683f6aa6d832fd60 https://code.google.com/p/go/ #

Patch Set 4 : diff -r 7b4959d789778872173938218fc966d019401a3a https://code.google.com/p/go/ #

Created: 10 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+29 lines, -29 lines)			Patch
M	src/pkg/runtime/cpuprof.goc	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	src/pkg/runtime/heapdump.c	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	src/pkg/runtime/malloc.h	View	1 2 3	3 chunks	+7 lines, -7 lines	0 comments	Download
M	src/pkg/runtime/malloc.c	View	1 2 3	3 chunks	+4 lines, -4 lines	0 comments	Download
M	src/pkg/runtime/mem_darwin.c	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	src/pkg/runtime/mem_dragonfly.c	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	src/pkg/runtime/mem_freebsd.c	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	src/pkg/runtime/mem_linux.c	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	src/pkg/runtime/mem_nacl.c	View	1	1 chunk	+3 lines, -3 lines	0 comments	Download
M	src/pkg/runtime/mem_netbsd.c	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	src/pkg/runtime/mem_openbsd.c	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	src/pkg/runtime/mem_plan9.c	View	1	2 chunks	+2 lines, -2 lines	0 comments	Download
M	src/pkg/runtime/mem_solaris.c	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	src/pkg/runtime/mem_windows.c	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	src/pkg/runtime/mheap.c	View	1 2 3	1 chunk	+1 line, -1 line	0 comments	Download
M	src/pkg/runtime/mprof.goc	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	src/pkg/runtime/stack.c	View	1	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

rsc

Hello golang-codereviews@googlegroups.com (cc: iant, mdempsky@google.com), I'd like you to review this change to https://code.google.com/p/go/

10 years, 6 months ago (2014-08-30 04:38:48 UTC) #1

mdempsky

LGTM (FWIW) and I'll then switch my CL to use sysAlloc() instead of &cpuProfile{}.

10 years, 6 months ago (2014-08-30 04:44:32 UTC) #2

rsc

*** Submitted as https://code.google.com/p/go/source/detail?r=c74a28c20ef2 *** runtime: rename SysAlloc to sysAlloc for Go Renaming the C ...

10 years, 6 months ago (2014-08-30 04:54:42 UTC) #3

gobot

10 years, 6 months ago (2014-08-30 04:57:34 UTC) #4

Message was sent while issue was closed.

This CL appears to have broken the windows-amd64-perf builder.
See http://build.golang.org/log/4b2d8076dadf6aebb5c4c62cc57717a7a1e46551

Expand All Messages | Collapse All Messages