Issue 14005043: Tweak internal logging

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 14005043: Tweak internal logging

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 7 months ago by thumper

Modified:
10 years, 7 months ago

Reviewers:
mp+187953, wallyworld

Visibility:
Public.

Description

Tweak internal logging These are logging changes that happend while debugging a schema validation failure. Worth keeping IMO. https://code.launchpad.net/~thumper/juju-core/tweak-logging/+merge/187953 (do not edit description out of merge proposal)

Patch Set 1 #

Total comments: 1

Created: 10 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+24 lines, -14 lines)			Patch
A	[revision details]	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	environs/config/config.go	View	1 chunk	+1 line, -0 lines	1 comment	Download
M	provider/local/environprovider.go	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	rpc/client.go	View	2 chunks	+1 line, -3 lines	0 comments	Download
M	rpc/jsoncodec/codec.go	View	3 chunks	+8 lines, -5 lines	0 comments	Download
M	rpc/server.go	View	3 chunks	+6 lines, -3 lines	0 comments	Download
M	schema/schema.go	View	1 chunk	+1 line, -1 line	0 comments	Download
M	worker/environ.go	View	3 chunks	+4 lines, -2 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

wallyworld

10 years, 7 months ago (2013-09-26 23:40:35 UTC) #2

LGTM

https://codereview.appspot.com/14005043/diff/1/environs/config/config.go
File environs/config/config.go (right):

https://codereview.appspot.com/14005043/diff/1/environs/config/config.go#newc...
environs/config/config.go:590: logger.Errorf("coersion failed: %#v, %#v, %v",
attrs, checker, err)
Do we need a label in the output for each %v so the reader knows that they
represent? eg attrs: %#v, checker: %#v etc

Expand All Messages | Collapse All Messages