code review 139960043: runtime: make allp a static array

runtime: make allp a static array

It is anyway, just an allocated one.
Giving it a sized type makes Go access nicer.

[rsc, 2014-08-29 19:57:04]

Hello dvyukov (cc: golang-codereviews@googlegroups.com),

I'd like you to review this change to
https://code.google.com/p/go/

[iant, 2014-08-29 20:06:58]

LGTM

Can we put an actual definition in proc.c next to allm and friends?  Looks weird
to have it just be a common variable.

[rsc, 2014-08-29 20:21:53]

On Fri, Aug 29, 2014 at 4:06 PM, <iant@golang.org> wrote:

> LGTM
>
> Can we put an actual definition in proc.c next to allm and friends?
> Looks weird to have it just be a common variable.
>

Oh is _that_ where it goes!? When the compiler didn't yell at me I assumed
we just weren't defining them anymore.
(The translated Go version will provide a definition too. Since they are
both uninitialized they manage not to conflict.)

Thanks, will fix.

[rsc, 2014-08-29 20:41:13]

*** Submitted as https://code.google.com/p/go/source/detail?r=25c3a04e7b95 ***

runtime: make allp a static array

It is anyway, just an allocated one.
Giving it a sized type makes Go access nicer.

LGTM=iant
R=dvyukov, iant
CC=golang-codereviews
https://codereview.appspot.com/139960043

[gobot, 2014-08-29 20:42:33]

This CL appears to have broken the windows-amd64-perf builder.
See http://build.golang.org/log/8012fb36345753bf65cc83ff7118e3fbc678a2f0

[bradfitz, 2014-08-29 20:43:14]

Real:

# Building C bootstrap tool.
cmd/dist

# Building compilers and Go bootstrap tool.
runtime.chansend1: nosplit stack overflow
152 assumed on entry to runtime.chansend1
104 after runtime.chansend1 uses 48
96 on entry to runtime.chansend
160 after runtime.chansend uses -64
152 on entry to runtime.gopark
160 after runtime.gopark uses -8
152 on entry to runtime.gothrow
160 after runtime.gothrow uses -8
152 on entry to runtime.startpanic
160 after runtime.startpanic uses -8
152 on entry to runtime.printf
112 after runtime.printf uses 40
104 on entry to runtime.vprintf
160 after runtime.vprintf uses -56
152 on entry to runtime.gwrite
160 after runtime.gwrite uses -8
152 on entry to runtime.panicslice
160 after runtime.panicslice uses -8
152 on entry to runtime.convT2E
160 after runtime.convT2E uses -8
152 on entry to runtime.newobject
160 after runtime.newobject uses -8
152 on entry to runtime.gomallocgc
160 after runtime.gomallocgc uses -8
152 on entry to runtime.gogc
160 after runtime.gogc uses -8
152 on entry to runtime.stoptheworld
160 after runtime.stoptheworld uses -8
152 on entry to runtime.notetsleep
160 after runtime.notetsleep uses -8
152 on entry to runtime.notetsleep_internal
104 after runtime.notetsleep_internal uses 48
96 on entry to runtime.semasleep
64 after runtime.semasleep uses 32
56 on entry to runtime.stdcall2
40 after runtime.stdcall2 uses 16
32 on entry to stdcall
16 after stdcall uses 16
8 on entry to runtime.asmcgocall
0 on entry to function pointer
-8 on entry to runtime.morestack
lib9
libbio
liblink
misc/pprof



On Fri, Aug 29, 2014 at 1:42 PM, <gobot@golang.org> wrote:

> This CL appears to have broken the windows-amd64-perf builder.
> See http://build.golang.org/log/8012fb36345753bf65cc83ff7118e3fbc678a2f0
>
>
> https://codereview.appspot.com/139960043/
>
> --
> You received this message because you are subscribed to the Google Groups
> "golang-codereviews" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to golang-codereviews+unsubscribe@googlegroups.com.
> For more options, visit https://groups.google.com/d/optout.
>

[iant, 2014-08-29 20:50:25]

On Fri, Aug 29, 2014 at 1:42 PM,  <gobot@golang.org> wrote:
> This CL appears to have broken the windows-amd64-perf builder.
> See http://build.golang.org/log/8012fb36345753bf65cc83ff7118e3fbc678a2f0
>
> https://codereview.appspot.com/139960043/

This is real.

# Building compilers and Go bootstrap tool.
runtime.chansend1: nosplit stack overflow
152 assumed on entry to runtime.chansend1
104 after runtime.chansend1 uses 48
96 on entry to runtime.chansend
160 after runtime.chansend uses -64
152 on entry to runtime.gopark
160 after runtime.gopark uses -8
152 on entry to runtime.gothrow
160 after runtime.gothrow uses -8
152 on entry to runtime.startpanic
160 after runtime.startpanic uses -8
152 on entry to runtime.printf
112 after runtime.printf uses 40
104 on entry to runtime.vprintf
160 after runtime.vprintf uses -56
152 on entry to runtime.gwrite
160 after runtime.gwrite uses -8
152 on entry to runtime.panicslice
160 after runtime.panicslice uses -8
152 on entry to runtime.convT2E
160 after runtime.convT2E uses -8
152 on entry to runtime.newobject
160 after runtime.newobject uses -8
152 on entry to runtime.gomallocgc
160 after runtime.gomallocgc uses -8
152 on entry to runtime.gogc
160 after runtime.gogc uses -8
152 on entry to runtime.stoptheworld
160 after runtime.stoptheworld uses -8
152 on entry to runtime.notetsleep
160 after runtime.notetsleep uses -8
152 on entry to runtime.notetsleep_internal
104 after runtime.notetsleep_internal uses 48
96 on entry to runtime.semasleep
64 after runtime.semasleep uses 32
56 on entry to runtime.stdcall2
40 after runtime.stdcall2 uses 16
32 on entry to stdcall
16 after stdcall uses 16
8 on entry to runtime.asmcgocall
0 on entry to function pointer
-8 on entry to runtime.morestack