Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(280)

Issue 139930043: code review 139930043: runtime: convert lock*.c to Go (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 6 months ago by rsc
Modified:
10 years, 6 months ago
Reviewers:
r, gobot, iant
CC:
golang-codereviews, r, iant, dvyukov, khr
Visibility:
Public.

Description

runtime: convert lock*.c to Go

Patch Set 1 #

Patch Set 2 : diff -r 25ae16c918f65ca0e0039d74109aaeefa716d987 https://code.google.com/p/go/ #

Patch Set 3 : diff -r 25ae16c918f65ca0e0039d74109aaeefa716d987 https://code.google.com/p/go/ #

Patch Set 4 : diff -r 25ae16c918f65ca0e0039d74109aaeefa716d987 https://code.google.com/p/go/ #

Patch Set 5 : diff -r 25ae16c918f65ca0e0039d74109aaeefa716d987 https://code.google.com/p/go/ #

Patch Set 6 : diff -r 25ae16c918f65ca0e0039d74109aaeefa716d987 https://code.google.com/p/go/ #

Patch Set 7 : diff -r 25ae16c918f65ca0e0039d74109aaeefa716d987 https://code.google.com/p/go/ #

Patch Set 8 : diff -r 25ae16c918f65ca0e0039d74109aaeefa716d987 https://code.google.com/p/go/ #

Patch Set 9 : diff -r 173175ba9eb71f00f69da09c738523eb4fab36a6 https://go.googlecode.com/hg #

Patch Set 10 : diff -r 173175ba9eb71f00f69da09c738523eb4fab36a6 https://go.googlecode.com/hg #

Patch Set 11 : diff -r 91378329bf67c315e56119764bfb0edbb640a5ba https://code.google.com/p/go/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+388 lines, -428 lines) Patch
M src/pkg/runtime/alg.go View 1 2 3 4 5 6 7 8 9 10 1 chunk +2 lines, -2 lines 0 comments Download
M src/pkg/runtime/asm_386.s View 1 2 1 chunk +3 lines, -0 lines 0 comments Download
M src/pkg/runtime/asm_amd64.s View 1 2 1 chunk +3 lines, -0 lines 0 comments Download
M src/pkg/runtime/asm_amd64p32.s View 1 2 1 chunk +3 lines, -0 lines 0 comments Download
M src/pkg/runtime/asm_arm.s View 1 2 1 chunk +3 lines, -0 lines 0 comments Download
M src/pkg/runtime/export_futex_test.go View 1 2 3 4 5 6 7 8 1 chunk +0 lines, -3 lines 0 comments Download
M src/pkg/runtime/export_test.go View 1 2 3 4 5 6 7 8 1 chunk +0 lines, -1 line 0 comments Download
M src/pkg/runtime/lock_futex.go View 1 2 3 4 5 6 7 8 3 chunks +133 lines, -155 lines 0 comments Download
M src/pkg/runtime/lock_sema.go View 1 2 3 4 5 6 3 chunks +177 lines, -208 lines 0 comments Download
M src/pkg/runtime/os_darwin.go View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M src/pkg/runtime/os_dragonfly.go View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M src/pkg/runtime/os_freebsd.go View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M src/pkg/runtime/os_linux.go View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M src/pkg/runtime/os_nacl.go View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M src/pkg/runtime/os_netbsd.go View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M src/pkg/runtime/os_openbsd.go View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M src/pkg/runtime/os_plan9.go View 1 2 1 chunk +4 lines, -0 lines 0 comments Download
M src/pkg/runtime/os_solaris.go View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M src/pkg/runtime/os_windows.go View 1 2 3 4 5 6 7 8 9 10 1 chunk +2 lines, -0 lines 0 comments Download
M src/pkg/runtime/stack.go View 1 2 2 chunks +32 lines, -46 lines 0 comments Download
M src/pkg/runtime/stubs.go View 1 2 3 4 5 6 7 8 9 10 6 chunks +10 lines, -13 lines 0 comments Download

Messages

Total messages: 7
rsc
Hello golang-codereviews@googlegroups.com (cc: dvyukov, iant, khr, r), I'd like you to review this change to ...
10 years, 6 months ago (2014-08-29 19:35:05 UTC) #1
r
LGTM for style but there appears to be logic changes or rearrangements i'd like someone ...
10 years, 6 months ago (2014-08-29 19:54:52 UTC) #2
rsc
There are no logic changes. Everything is supposed to be line-for-line semantically identical to what ...
10 years, 6 months ago (2014-08-29 19:59:45 UTC) #3
iant
LGTM
10 years, 6 months ago (2014-08-29 20:03:07 UTC) #4
r
I see now. I was confused by some misalignments in the diffs.
10 years, 6 months ago (2014-08-29 20:07:45 UTC) #5
rsc
*** Submitted as https://code.google.com/p/go/source/detail?r=f728cbecbbae *** runtime: convert lock*.c to Go LGTM=r, iant R=golang-codereviews, r, iant ...
10 years, 6 months ago (2014-08-29 20:20:51 UTC) #6
gobot
10 years, 6 months ago (2014-08-29 20:22:26 UTC) #7
Message was sent while issue was closed.
This CL appears to have broken the windows-amd64-perf builder.
See http://build.golang.org/log/d8bb6e25c2bc98ed5c04c8080e639341373c983e
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b