Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1969)

Issue 13986043: Give user the option to reload the config viewlet

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 8 months ago by matthew.scott
Modified:
10 years, 7 months ago
Reviewers:
jeff.pihach, mp+187883
Visibility:
Public.

Description

Give user the option to reload the config viewlet After a charm has been changed on a service, the config may or may not have different/more/fewer options, but those changes may have occurred out of view (same as sticky-headers problem), so give the users the option to reload the config viewlet. This also cancels the notification. As before, to QA, create a service, then run `app.db.services.item(0).set('charmChanged', true)` in the JS console. https://code.launchpad.net/~makyo/juju-gui/upgrade-reload-inspector/+merge/187883 (do not edit description out of merge proposal)

Patch Set 1 #

Total comments: 3

Patch Set 2 : Give user the option to reload the config viewlet #

Patch Set 3 : Give user the option to reload the config viewlet #

Total comments: 1

Patch Set 4 : Give user the option to reload the config viewlet #

Unified diffs Side-by-side diffs Delta from patch set Stats (+83 lines, -25 lines) Patch
A [revision details] View 1 2 3 1 chunk +2 lines, -0 lines 0 comments Download
M app/templates/inspector-header.handlebars View 1 chunk +1 line, -1 line 0 comments Download
M app/views/environment.js View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M app/views/inspector.js View 1 2 3 1 chunk +18 lines, -0 lines 0 comments Download
M app/views/viewlet-manager.js View 1 2 chunks +26 lines, -12 lines 0 comments Download
M app/views/viewlets/inspector-header.js View 1 2 1 chunk +9 lines, -4 lines 0 comments Download
M app/views/viewlets/service-config.js View 1 4 chunks +19 lines, -7 lines 0 comments Download
M test/test_inspector_overview.js View 1 2 3 2 chunks +7 lines, -1 line 0 comments Download

Messages

Total messages: 7
matthew.scott
Please take a look.
10 years, 8 months ago (2013-09-26 19:29:38 UTC) #1
jeff.pihach
Thanks for getting this done! Please see my questions below. https://codereview.appspot.com/13986043/diff/1/app/templates/inspector-header.handlebars File app/templates/inspector-header.handlebars (right): https://codereview.appspot.com/13986043/diff/1/app/templates/inspector-header.handlebars#newcode26 ...
10 years, 8 months ago (2013-09-26 19:39:04 UTC) #2
jeff.pihach
QA NO GO See comment below for resolution. https://codereview.appspot.com/13986043/diff/1/app/views/inspector.js File app/views/inspector.js (right): https://codereview.appspot.com/13986043/diff/1/app/views/inspector.js#newcode931 app/views/inspector.js:931: viewlet.render(this.model, ...
10 years, 8 months ago (2013-09-26 20:19:23 UTC) #3
matthew.scott
Please take a look.
10 years, 7 months ago (2013-09-27 20:37:27 UTC) #4
matthew.scott
Please take a look.
10 years, 7 months ago (2013-09-30 16:10:38 UTC) #5
jeff.pihach
LGTM Thanks again for all the iterations on this! QA OK
10 years, 7 months ago (2013-09-30 16:33:57 UTC) #6
matthew.scott
10 years, 7 months ago (2013-09-30 16:54:06 UTC) #7
*** Submitted:

Give user the option to reload the config viewlet

After a charm has been changed on a service, the config may or may not have
different/more/fewer options, but those changes may have occurred out of view
(same as sticky-headers problem), so give the users the option to reload the
config viewlet.  This also cancels the notification.

As before, to QA, create a service, then run
`app.db.services.item(0).set('charmChanged', true)` in the JS console.

R=jeff.pihach
CC=
https://codereview.appspot.com/13986043

https://codereview.appspot.com/13986043/diff/12001/app/views/environment.js
File app/views/environment.js (right):

https://codereview.appspot.com/13986043/diff/12001/app/views/environment.js#n...
app/views/environment.js:195: '.rerender-config': {click: 'rerenderConfig'},
D'oh, I'll rename these to reloadInspector or something.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b