environs: store bootstrap config in info

environs: store bootstrap config in info

Also change the juju package so it connects using that info when
available.  However currently we can't rely on having it because old
juju environments will have no environment info file, so we fall back
to using the original configuration attributes as before.

https://code.launchpad.net/~rogpeppe/juju-core/419-juju-use-bootstrap-attrs/+merge/187788

(do not edit description out of merge proposal)

[rog, 2013-09-26 16:25:55]

Please take a look.

[natefinch, 2013-09-26 18:13:29]

LGTM with just the one super minor thing

https://codereview.appspot.com/13970043/diff/9001/juju/api.go
File juju/api.go (right):

https://codereview.appspot.com/13970043/diff/9001/juju/api.go#newcode126
juju/api.go:126: if !errors.IsNotFoundError(err) {
Seems like you could combine the two if statements... I found it confusing to
have them separated, I almost thought you had accidentally missed handling some
error.

https://codereview.appspot.com/13970043/diff/9001/juju/apiconn_test.go
File juju/apiconn_test.go (right):

https://codereview.appspot.com/13970043/diff/9001/juju/apiconn_test.go#newcod...
juju/apiconn_test.go:355: // so it has a different environment name.
really really happy to see the comment describing the test. It makes a huge
difference in figuring out what the test is supposed to be testing and how

[rog, 2013-09-26 18:29:44]

Please take a look.

https://codereview.appspot.com/13970043/diff/9001/juju/api.go
File juju/api.go (right):

https://codereview.appspot.com/13970043/diff/9001/juju/api.go#newcode126
juju/api.go:126: if !errors.IsNotFoundError(err) {
On 2013/09/26 18:13:29, nate.finch wrote:
> Seems like you could combine the two if statements... I found it confusing to
> have them separated, I almost thought you had accidentally missed handling
some
> error.

Done.