Issue 13968043: testing: try harder to reconnect in MgoReset

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 13968043: testing: try harder to reconnect in MgoReset

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 7 months ago by rog

Modified:
10 years, 7 months ago

Reviewers:
mp+187781, jameinel

Visibility:
Public.

Description

testing: try harder to reconnect in MgoReset We were restarting the mongo server on almost every test because the dummy provider sets the admin password. This makes the situation better, although there are probably places that use a different testing admin secret still. https://code.launchpad.net/~rogpeppe/juju-core/421-better-mgoreset/+merge/187781 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : testing: try harder to reconnect in MgoReset #

Total comments: 2

Created: 10 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+59 lines, -15 lines)			Patch
A	[revision details]	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	provider/dummy/environs.go	View	1 chunk	+1 line, -1 line	0 comments	Download
M	testing/environ.go	View	3 chunks	+5 lines, -3 lines	0 comments	Download
M	testing/mgo.go	View	1 chunk	+51 lines, -11 lines	2 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

jameinel

LGTM small comment tweak https://codereview.appspot.com/13968043/diff/3001/testing/mgo.go File testing/mgo.go (right): https://codereview.appspot.com/13968043/diff/3001/testing/mgo.go#newcode269 testing/mgo.go:269: // We need to try ...

10 years, 7 months ago (2013-09-29 09:22:06 UTC) #2

rog

10 years, 7 months ago (2013-10-02 09:27:44 UTC) #3

https://codereview.appspot.com/13968043/diff/3001/testing/mgo.go
File testing/mgo.go (right):

https://codereview.appspot.com/13968043/diff/3001/testing/mgo.go#newcode269
testing/mgo.go:269: // We need to try several passwords because we don't
On 2013/09/29 09:22:06, jameinel wrote:
> "we don't *know*" 

Done.

Expand All Messages | Collapse All Messages