code review 13965043: freetype/truetype: implement IUP opcode.

freetype/truetype: implement IUP opcode.

[nigeltao, 2013-09-26 12:18:28]

Hello bsiegert@gmail.com (cc: golang-dev@googlegroups.com),

I'd like you to review this change to
https://code.google.com/p/freetype-go

[bsiegert, 2013-09-26 12:21:33]

Could you re-upload this? I get "Old chunk mismatch".

[nigeltao, 2013-09-26 12:25:40]

PTAL.

[bsiegert, 2013-09-28 15:58:37]

LGTM

That said, I have a hard time figuring out what iupInterp actually does. It
looks more like C than Go, with lots of variables with short names. Or is it
just a translation of the equivalent freetype code?

https://codereview.appspot.com/13965043/diff/15001/freetype/truetype/hint.go
File freetype/truetype/hint.go (right):

https://codereview.appspot.com/13965043/diff/15001/freetype/truetype/hint.go#...
freetype/truetype/hint.go:1067: func (h *Hinter) iupInterp(interpY bool, p1, p2,
ref1, ref2 int) {
doc comment?

[nigeltao, 2013-09-29 02:06:19]

On Sun, Sep 29, 2013 at 1:58 AM,  <bsiegert@gmail.com> wrote:
> That said, I have a hard time figuring out what iupInterp actually does.
> It looks more like C than Go, with lots of variables with short names.
> Or is it just a translation of the equivalent freetype code?

It is a translation of the equivalent Freetype C code. Look for
_iup_worker_interpolate in
http://ghostscript.com/~tor/gs-browse/gs/freetype/src/truetype/ttinterp.c.html
except that the Go code obviously cannot do pointer arithmetic when
initializing the IUP_WorkerRec fields.

Either way, the code kind of assumes that the real documentation for
e.g. the IUP instruction is
https://developer.apple.com/fonts/TTRefMan/RM05/Chap5.html#IUP

[nigeltao, 2013-09-29 02:09:24]

*** Submitted as
https://code.google.com/p/freetype-go/source/detail?r=3ebd703fd260 ***

freetype/truetype: implement IUP opcode.

R=bsiegert
CC=golang-dev
https://codereview.appspot.com/13965043