Issue 139560045: code review 139560045: cmd/gc: fix racewalk after writebarrier change

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 139560045: code review 139560045: cmd/gc: fix racewalk after writebarrier change (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 7 months ago by dvyukov

Modified:
10 years, 7 months ago

Reviewers:
gobot, rsc

CC:
rsc, golang-codereviews

Visibility:
Public.

Description

cmd/gc: fix racewalk after writebarrier change Instrument dst argument of writebarrier calls.

Patch Set 2 : diff -r 6e76bf4838e34814288ed3596a6d0792119c4684 https://dvyukov%40google.com@code.google.com/p/go/ #

Patch Set 3 : diff -r 6e76bf4838e34814288ed3596a6d0792119c4684 https://dvyukov%40google.com@code.google.com/p/go/ #

Total comments: 1

Patch Set 4 : diff -r 88f49b2e7534aa873a043a5e922ea60eb6a8e695 https://dvyukov%40google.com@code.google.com/p/go/ #

Created: 10 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+25 lines, -0 lines)			Patch
	M	src/cmd/gc/racewalk.c	View	1 2 3	1 chunk	+25 lines, -0 lines	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

dvyukov

Hello rsc@golang.org (cc: golang-codereviews@googlegroups.com), I'd like you to review this change to https://dvyukov%40google.com@code.google.com/p/go/

10 years, 7 months ago (2014-09-12 18:24:18 UTC) #1

rsc

LGTM thanks https://codereview.appspot.com/139560045/diff/40001/src/cmd/gc/racewalk.c File src/cmd/gc/racewalk.c (right): https://codereview.appspot.com/139560045/diff/40001/src/cmd/gc/racewalk.c#newcode219 src/cmd/gc/racewalk.c:219: // First the dst argument. s/First/Find/

10 years, 7 months ago (2014-09-12 19:04:41 UTC) #2

dvyukov

On Fri, Sep 12, 2014 at 12:04 PM, <rsc@golang.org> wrote: > LGTM > thanks > ...

10 years, 7 months ago (2014-09-12 22:05:15 UTC) #3

dvyukov

*** Submitted as https://code.google.com/p/go/source/detail?r=f37aaa031156 *** cmd/gc: fix racewalk after writebarrier change Instrument dst argument of ...

10 years, 7 months ago (2014-09-12 22:05:29 UTC) #4

gobot

10 years, 7 months ago (2014-09-12 22:08:17 UTC) #5

Message was sent while issue was closed.

This CL appears to have broken the windows-amd64-perf builder.
See http://build.golang.org/log/a6deaeae371f10985c1f2c7788966adba8c04ded

Expand All Messages | Collapse All Messages