code review 139560044: runtime: save correct pid for new m's on plan9/amd64

runtime: save correct pid for new m's on plan9/amd64

The pid field in the Tos structure is a 32-bit value.
Loading a 64-bit word also brings in the next field
which is used for the profiling clock.

[ality, 2014-09-12 07:43:17]

Hello rsc@golang.org (cc: 0intro@gmail.com, aram@mgk.ro,
golang-codereviews@googlegroups.com, mischief@offblast.org),

I'd like you to review this change to
https://code.google.com/p/go

[0intro, 2014-09-12 07:57:48]

LGTM

[aram, 2014-09-12 08:04:33]

LGTM

[ality, 2014-09-12 08:21:11]

0intro@gmail.com once said:
> LGTM

I'm going to submit this. It's small enough and it's
fixing a bug so I don't think Russ will have any
objection.

[ality, 2014-09-12 08:22:06]

*** Submitted as https://code.google.com/p/go/source/detail?r=acc325ce0f2e ***

runtime: save correct pid for new m's on plan9/amd64

The pid field in the Tos structure is a 32-bit value.
Loading a 64-bit word also brings in the next field
which is used for the profiling clock.

LGTM=0intro, aram
R=rsc, 0intro, aram
CC=golang-codereviews, mischief
https://codereview.appspot.com/139560044

[0intro, 2014-09-12 08:23:03]

> I'm going to submit this. It's small enough and it's
> fixing a bug so I don't think Russ will have any
> objection.

Yes, and it's only affecting Plan 9 amd64 anyway.

[ality, 2014-09-12 08:56:24]

A nice "ok" to top off a big column of "fail".
Let's see if it lasts. ☺

  Anthony

[lucio, 2014-09-12 09:47:40]

That was nothing short of "inspired".

I'll have to build me a 64-bit Plan 9 box, now.

Lucio.

PS: I'm hoping to hear from you about 9vx, now that you seem to be
back in 9-land :-) (no hurry, though!)

On 9/12/14, Anthony Martin <ality@pbrane.org> wrote:
> A nice "ok" to top off a big column of "fail".
> Let's see if it lasts. ☺
>
>   Anthony
>
> --
> You received this message because you are subscribed to the Google Groups
> "golang-codereviews" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to golang-codereviews+unsubscribe@googlegroups.com.
> For more options, visit https://groups.google.com/d/optout.
>

[aram, 2014-09-12 09:52:37]

This was my fault. We need typed assembly language:
http://research.microsoft.com/en-us/projects/talproj

There were another two hard to find bugs that were caused by me using a MOVQ
instead of MOVL.

[lucio, 2014-09-12 10:01:06]

It's still inspired!  You're all doing great work.  I do wish I was in
a better place, intellectually and geographically, to be of help.

Lucio.


On 9/12/14, aram@mgk.ro <aram@mgk.ro> wrote:
> This was my fault. We need typed assembly language:
> http://research.microsoft.com/en-us/projects/talproj
>
> There were another two hard to find bugs that were caused by me using a
> MOVQ instead of MOVL.
>
> https://codereview.appspot.com/139560044/
>