Issue 13954043: Add bundle page HTML

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 13954043: Add bundle page HTML (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 7 months ago by huwshimi

Modified:
10 years, 7 months ago

Reviewers:
mp+187644

Visibility:
Public.

Description

Add bundle page HTML This branch adds an HTML shell for the bundle page. There is currently no way to view this page. It also trivially modifies the CSS to pick up the appropriate styles. You can somewhat test the contents of this page by replace the contents of app/subapps/browser/templates/browser_charm.handlebars with the contents of app/templates/bundle.handlebars and navigation to a charm in the sidebar browser. I've added the HTML to an arbitrary template location, this is not necessarily intended to be used as is. I'm not sure if this really needs to be merged or if it just needs to be pulled in by whoever implements this page. https://code.launchpad.net/~huwshimi/juju-gui/bundle-templates/+merge/187644 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : Add bundle page HTML #

Created: 10 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+130 lines, -4 lines)			Patch
A	[revision details]	View	1 chunk	+2 lines, -0 lines	0 comments	Download
A	app/templates/bundle.handlebars	View	1 chunk	+123 lines, -0 lines	0 comments	Download
M	lib/views/browser/charm-full.less	View	3 chunks	+5 lines, -4 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

huwshimi

10 years, 7 months ago (2013-09-26 23:52:17 UTC) #2

*** Submitted:

Add bundle page HTML

This branch adds an HTML shell for the bundle page. There is currently no way to
view this page. It also trivially modifies the CSS to pick up the appropriate
styles.

You can somewhat test the contents of this page by replace the contents of
app/subapps/browser/templates/browser_charm.handlebars with the contents of
app/templates/bundle.handlebars and navigation to a charm in the sidebar
browser.

I've added the HTML to an arbitrary template location, this is not necessarily
intended to be used as is.

I'm not sure if this really needs to be merged or if it just needs to be pulled
in by whoever implements this page.

R=
CC=
https://codereview.appspot.com/13954043

Expand All Messages | Collapse All Messages