Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(4386)

Issue 1395041: code review 1395041: goinstall: Use 'git pull' instead of 'git checkout' whe...

Can't Edit
Can't Publish+Mail
Start Review
Created:
9 years, 5 months ago by hoisie
Modified:
1 month ago
Reviewers:
rsc
CC:
rsc, golang-dev
Visibility:
Public.

Description

goinstall: Use 'git pull' instead of 'git checkout' when updating a git repo.

Patch Set 1 #

Patch Set 2 : code review 1395041: goinstall: Use 'git pull' instead of 'git checkout' whe... #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M src/cmd/goinstall/download.go View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4
hoisie
Hello rsc (cc: golang-dev@googlegroups.com), I'd like you to review this change.
9 years, 5 months ago (2010-05-28 21:22:06 UTC) #1
hoisie
'git checkout' is used to switch branches in a repo. It doesn't actually incorporate the ...
9 years, 5 months ago (2010-05-28 21:30:07 UTC) #2
rsc
LGTM On Fri, May 28, 2010 at 14:22, <hoisie@gmail.com> wrote: > Reviewers: rsc, > > ...
9 years, 5 months ago (2010-05-28 21:31:41 UTC) #3
rsc
9 years, 5 months ago (2010-06-01 21:27:52 UTC) #4
*** Submitted as http://code.google.com/p/go/source/detail?r=d0adafd98693 ***

goinstall: Use 'git pull' instead of 'git checkout' when updating a git repo.

R=rsc
CC=golang-dev
http://codereview.appspot.com/1395041

Committer: Russ Cox <rsc@golang.org>
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b