Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(456)

Issue 139350043: Updated quickstart dependencies for utopic.

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 7 months ago by frankban
Modified:
10 years, 7 months ago
Reviewers:
rharding, jeff.pihach, mp+233770
Visibility:
Public.

Description

Updated quickstart dependencies for utopic. Quickstart now uses the dependency versions we expect to be available in utopic. Update the code parts in which quickstart interacts with the juju client and the websocket Python libraries: ensure we only log the textual WebSocket messages we are interested in. Also remove the deprecated --use-mirrors pip option. Tests: `make check` QA: Use quickstart as usual to bootstrap local, ec2 and HP environments: `.venv/bin/python juju-quickstart -e ...` https://code.launchpad.net/~frankban/juju-quickstart/utopic-update-dependencies/+merge/233770 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : Updated quickstart dependencies for utopic. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+58 lines, -30 lines) Patch
M Makefile View 1 chunk +1 line, -1 line 0 comments Download
A [revision details] View 1 chunk +2 lines, -0 lines 0 comments Download
M quickstart/juju.py View 2 chunks +22 lines, -11 lines 0 comments Download
M quickstart/tests/helpers.py View 1 chunk +5 lines, -2 lines 0 comments Download
M quickstart/tests/test_juju.py View 5 chunks +22 lines, -10 lines 0 comments Download
M requirements.pip View 1 chunk +4 lines, -4 lines 0 comments Download
M test-requirements.pip View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 4
frankban
Please take a look.
10 years, 7 months ago (2014-09-08 18:10:52 UTC) #1
rharding
LGTM no qa
10 years, 7 months ago (2014-09-08 18:17:04 UTC) #2
jeff.pihach
LGTM qa ok!
10 years, 7 months ago (2014-09-08 20:10:49 UTC) #3
frankban
10 years, 7 months ago (2014-09-08 20:14:41 UTC) #4
*** Submitted:

Updated quickstart dependencies for utopic.

Quickstart now uses the dependency versions we
expect to be available in utopic.

Update the code parts in which quickstart interacts
with the juju client and the websocket Python
libraries: ensure we only log the textual WebSocket
messages we are interested in.

Also remove the deprecated --use-mirrors pip option.

Tests: `make check`

QA:
Use quickstart as usual to bootstrap local, ec2 and HP
environments: `.venv/bin/python juju-quickstart -e ...`

R=rharding, jeff.pihach
CC=
https://codereview.appspot.com/139350043
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b