Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(81)

Issue 139110043: code review 139110043: runtime: convert a few traceback-related functions from... (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 6 months ago by rsc
Modified:
10 years, 6 months ago
Reviewers:
r, gobot, bradfitz
CC:
golang-codereviews, r, dvyukov, iant, khr
Visibility:
Public.

Description

runtime: convert a few traceback-related functions from proc.c to traceback.go They were in proc.c mainly because there was no portable traceback source file. As part of converting them to Go, move to traceback.go. In order to get access to the PC of _rt0_go, rename to runtime.rt0_go.

Patch Set 1 #

Patch Set 2 : diff -r 9227fb9e97fdaddfab9a43aa3894178c14284e6b https://code.google.com/p/go/ #

Patch Set 3 : diff -r 9227fb9e97fdaddfab9a43aa3894178c14284e6b https://code.google.com/p/go/ #

Patch Set 4 : diff -r 9227fb9e97fdaddfab9a43aa3894178c14284e6b https://code.google.com/p/go/ #

Patch Set 5 : diff -r 9227fb9e97fdaddfab9a43aa3894178c14284e6b https://code.google.com/p/go/ #

Patch Set 6 : diff -r 0b83bb7bb7ec705538e89577c4f0da9ff37b4fbe https://code.google.com/p/go/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+158 lines, -167 lines) Patch
M src/cmd/api/goapi.go View 1 2 3 4 5 1 chunk +11 lines, -1 line 0 comments Download
M src/pkg/runtime/asm_386.s View 1 2 1 chunk +1 line, -1 line 0 comments Download
M src/pkg/runtime/asm_amd64.s View 1 2 1 chunk +1 line, -1 line 0 comments Download
M src/pkg/runtime/asm_amd64p32.s View 1 2 1 chunk +1 line, -1 line 0 comments Download
M src/pkg/runtime/asm_arm.s View 1 2 1 chunk +1 line, -1 line 0 comments Download
M src/pkg/runtime/proc.c View 1 2 3 4 chunks +3 lines, -125 lines 0 comments Download
M src/pkg/runtime/rt0_darwin_386.s View 1 2 1 chunk +1 line, -1 line 0 comments Download
M src/pkg/runtime/rt0_darwin_amd64.s View 1 2 1 chunk +1 line, -1 line 0 comments Download
M src/pkg/runtime/rt0_dragonfly_386.s View 1 2 1 chunk +1 line, -1 line 0 comments Download
M src/pkg/runtime/rt0_dragonfly_amd64.s View 1 2 1 chunk +1 line, -1 line 0 comments Download
M src/pkg/runtime/rt0_freebsd_386.s View 1 2 1 chunk +1 line, -1 line 0 comments Download
M src/pkg/runtime/rt0_freebsd_amd64.s View 1 2 1 chunk +1 line, -1 line 0 comments Download
M src/pkg/runtime/rt0_freebsd_arm.s View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M src/pkg/runtime/rt0_linux_386.s View 1 2 1 chunk +1 line, -1 line 0 comments Download
M src/pkg/runtime/rt0_linux_amd64.s View 1 2 1 chunk +1 line, -1 line 0 comments Download
M src/pkg/runtime/rt0_linux_arm.s View 1 2 1 chunk +1 line, -1 line 0 comments Download
M src/pkg/runtime/rt0_nacl_386.s View 1 2 1 chunk +1 line, -1 line 0 comments Download
M src/pkg/runtime/rt0_nacl_amd64p32.s View 1 2 1 chunk +1 line, -1 line 0 comments Download
M src/pkg/runtime/rt0_nacl_arm.s View 1 2 1 chunk +1 line, -1 line 0 comments Download
M src/pkg/runtime/rt0_netbsd_386.s View 1 2 1 chunk +1 line, -1 line 0 comments Download
M src/pkg/runtime/rt0_netbsd_amd64.s View 1 2 1 chunk +1 line, -1 line 0 comments Download
M src/pkg/runtime/rt0_netbsd_arm.s View 1 2 1 chunk +1 line, -1 line 0 comments Download
M src/pkg/runtime/rt0_openbsd_386.s View 1 2 1 chunk +1 line, -1 line 0 comments Download
M src/pkg/runtime/rt0_openbsd_amd64.s View 1 2 1 chunk +1 line, -1 line 0 comments Download
M src/pkg/runtime/rt0_plan9_386.s View 1 2 1 chunk +1 line, -1 line 0 comments Download
M src/pkg/runtime/rt0_plan9_amd64.s View 1 2 1 chunk +1 line, -1 line 0 comments Download
M src/pkg/runtime/rt0_solaris_amd64.s View 1 2 1 chunk +1 line, -1 line 0 comments Download
M src/pkg/runtime/rt0_windows_386.s View 1 2 1 chunk +1 line, -1 line 0 comments Download
M src/pkg/runtime/rt0_windows_amd64.s View 1 2 1 chunk +1 line, -1 line 0 comments Download
M src/pkg/runtime/runtime.h View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M src/pkg/runtime/stubs.go View 1 2 chunks +0 lines, -4 lines 0 comments Download
M src/pkg/runtime/traceback.go View 1 2 4 2 chunks +115 lines, -6 lines 0 comments Download
M src/pkg/runtime/traceback_windows.go View 1 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 5
rsc
Hello golang-codereviews@googlegroups.com (cc: dvyukov, iant, khr, r), I'd like you to review this change to ...
10 years, 6 months ago (2014-09-03 00:42:52 UTC) #1
r
LGTM
10 years, 6 months ago (2014-09-03 01:01:45 UTC) #2
rsc
*** Submitted as https://code.google.com/p/go/source/detail?r=a90503e16fd4 *** runtime: convert a few traceback-related functions from proc.c to traceback.go ...
10 years, 6 months ago (2014-09-03 15:11:21 UTC) #3
gobot
This CL appears to have broken the linux-amd64-temp builder. See http://build.golang.org/log/b888ebfc95d2fe1835fdc75ad64f97fa831b8482
10 years, 6 months ago (2014-09-03 15:25:40 UTC) #4
bradfitz
10 years, 6 months ago (2014-09-03 15:28:39 UTC) #5
We've seen a number of these recently on the new GCE-based builders:

--- FAIL: TestGcLastTime (0.00s)
gc_test.go:170: bad last GC pause: got 0, want [0, 10e9]
FAIL
FAIL runtime 14.756s


They're not heavily loaded. They have 16 cores, tons of RAM (not swapping)
and are only doing at most 6 builds at once, but usually they're pretty
idle.

Dmitry, can this test be less (not) flaky?



On Wed, Sep 3, 2014 at 8:25 AM, <gobot@golang.org> wrote:

> This CL appears to have broken the linux-amd64-temp builder.
> See http://build.golang.org/log/b888ebfc95d2fe1835fdc75ad64f97fa831b8482
>
>
> https://codereview.appspot.com/139110043/
>
> --
> You received this message because you are subscribed to the Google Groups
> "golang-codereviews" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to golang-codereviews+unsubscribe@googlegroups.com.
> For more options, visit https://groups.google.com/d/optout.
>
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b