code review 139110043: runtime: convert a few traceback-related functions from...

runtime: convert a few traceback-related functions from proc.c to traceback.go

They were in proc.c mainly because there was no portable
traceback source file. As part of converting them to Go,
move to traceback.go.

In order to get access to the PC of _rt0_go,
rename to runtime.rt0_go.

[rsc, 2014-09-03 00:42:52]

Hello golang-codereviews@googlegroups.com (cc: dvyukov, iant, khr, r),

I'd like you to review this change to
https://code.google.com/p/go/

[r, 2014-09-03 01:01:45]

LGTM

[rsc, 2014-09-03 15:11:21]

*** Submitted as https://code.google.com/p/go/source/detail?r=a90503e16fd4 ***

runtime: convert a few traceback-related functions from proc.c to traceback.go

They were in proc.c mainly because there was no portable
traceback source file. As part of converting them to Go,
move to traceback.go.

In order to get access to the PC of _rt0_go,
rename to runtime.rt0_go.

LGTM=r
R=golang-codereviews, r
CC=dvyukov, golang-codereviews, iant, khr
https://codereview.appspot.com/139110043

[gobot, 2014-09-03 15:25:40]

This CL appears to have broken the linux-amd64-temp builder.
See http://build.golang.org/log/b888ebfc95d2fe1835fdc75ad64f97fa831b8482

[bradfitz, 2014-09-03 15:28:39]

We've seen a number of these recently on the new GCE-based builders:

--- FAIL: TestGcLastTime (0.00s)
gc_test.go:170: bad last GC pause: got 0, want [0, 10e9]
FAIL
FAIL runtime 14.756s


They're not heavily loaded. They have 16 cores, tons of RAM (not swapping)
and are only doing at most 6 builds at once, but usually they're pretty
idle.

Dmitry, can this test be less (not) flaky?



On Wed, Sep 3, 2014 at 8:25 AM, <gobot@golang.org> wrote:

> This CL appears to have broken the linux-amd64-temp builder.
> See http://build.golang.org/log/b888ebfc95d2fe1835fdc75ad64f97fa831b8482
>
>
> https://codereview.appspot.com/139110043/
>
> --
> You received this message because you are subscribed to the Google Groups
> "golang-codereviews" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to golang-codereviews+unsubscribe@googlegroups.com.
> For more options, visit https://groups.google.com/d/optout.
>