Issue 13910043: Add a stand-in bundle token rendering.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 13910043: Add a stand-in bundle token rendering.

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 6 months ago by benji

Modified:
11 years, 6 months ago

Reviewers:
bac, mp+187539

Visibility:
Public.

Description

Add a stand-in bundle token rendering. https://code.launchpad.net/~benji/juju-gui/stand-in-bundle-token-3/+merge/187539 (do not edit description out of merge proposal)

Patch Set 2 : Add a stand-in bundle token rendering. #

Created: 11 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+52 lines, -7 lines)			Patch
A	[revision details]	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download
A	app/templates/bundle-token.handlebars	View		1 chunk	+6 lines, -0 lines	0 comments	Download
M	app/widgets/token.js	View		4 chunks	+13 lines, -5 lines	0 comments	Download
M	test/test_token.js	View	1	2 chunks	+31 lines, -2 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

bac

LGTM https://codereview.appspot.com/13910043/diff/1/test/test_token.js File test/test_token.js (right): https://codereview.appspot.com/13910043/diff/1/test/test_token.js#newcode147 test/test_token.js:147: it('can report the kind of object it represents', ...

11 years, 6 months ago (2013-09-25 15:26:56 UTC) #2

benji

Thanks for the review. I split the test into two. https://codereview.appspot.com/13910043/diff/1/test/test_token.js File test/test_token.js (right): https://codereview.appspot.com/13910043/diff/1/test/test_token.js#newcode147 ...

11 years, 6 months ago (2013-09-25 15:31:13 UTC) #3

benji

11 years, 6 months ago (2013-09-25 15:37:09 UTC) #4

*** Submitted:

Add a stand-in bundle token rendering.

R=bac
CC=
https://codereview.appspot.com/13910043

Expand All Messages | Collapse All Messages